fix(self-driving): keep a paused operational scout paused on rerun - #415
Open
posthog[bot] wants to merge 2 commits into
Open
posthog[bot] wants to merge 2 commits into
posthog[bot] wants to merge 2 commits into
Conversation
Step 6 told setup to update every disabled operational scout to enabled: true. That overrules a pause a person made and a pause the failure breaker owns, which Signals itself never resumes. scout-config-sync already resumes the pauses the harness made, so setup now leaves a still-disabled operational scout as it is and records a follow-up keyed on status and pause_reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 8faa167d-f453-42b5-ad52-3bb48ec1afcc
Contributor
Author
🦔 PostHog Review reviewed this pull requestFound 0 must fix, 1 should fix, 0 consider. Published 1 finding (view the review). Resolved comments: 1 fixed |
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a wizard branch:
Add Results will be posted here when complete. |
Contributor
Author
|
PostHog Review alpha 🦔 If you find any issues helpful - please reply "valid", "invalid", etc., for evaluation purposes 🙏 |
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
…l scout Step 1c counted only enabled operational scouts against max_enabled_scouts. A breaker-paused operational scout is disabled, so setup could give its slot to a troop scout. The breaker resume checks the cap and has no operational exemption, and scout-config-sync leaves repeated_failures pauses alone, so the lane could stay paused after a successful probe. Step 1c now reserves a slot for each breaker-paused operational scout. When the cap is already full, setup records a follow-up that names the cap as the blocker, and the step 3 breaker follow-up no longer promises a resume that cannot happen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: c9f4508e-5c80-4a4a-b443-6afde95694e0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
{ enabled: true }. That write also clears a failure-breaker pause, because the config API resumes apaused_by_systemrow onenabled: true.Origin
Changes
scout-config-syncalready runsreconcile_operational_configs, which resumes the pauses the harness made (inactivity-sweep pauses, and rows the seed created disabled). That sync is the server-supported recovery path.statusandpause_reasonand records one follow-up:paused_by_userpaused_by_system+repeated_failurespaused_by_system+ other reasonstatusfield (older deploy)Note
The config API does not expose
status_changed_byorstatus_changed_at, so setup cannot tell a pause from an earlier setup version apart from a person's pause. It leaves both off. PostHog'sresume_setup_paused_operational_scoutscommand repairs the setup-created ones server-side.Agent context
03b9fe1b(currentmaster):fleet_sync.materialize_scout_fleet→register_missing_configs→reconcile_operational_configs;SignalScoutConfigSerializerexposesstatusandpause_reasononly.enabled: truefor setup-created pauses. The API exposes no attribution field, and the sync already covers every pause the server can safely resume.npm testandnpm run buildpass. The change is prose only.Created with PostHog Desktop from this inbox report.
🤖 Generated with Claude Code