Repository navigation
FRLG Living Dex helper methods - #1808
Merged
Mysticial merged 2 commits intoNov 6, 2026
Merged
Conversation
Dalton-V
force-pushed
the
frlg-living-dex-helper
branch
from
November 5, 2026 13:47
8f0a3f5 to
edf5d45
Compare
Dalton-V
marked this pull request as ready for review
November 5, 2026 13:52
pa-devbot
reviewed
Nov 5, 2026
pa-devbot
left a comment
Collaborator
There was a problem hiding this comment.
AI review: Reviewed against the intended usage in #1614 (PokemonFRLG_BoxSorterLivingDex + BoxSorter_Tests).
Verification
- Built the branch (CMake+Ninja like CI): compiles cleanly.
- Full command-line test suite: 20,335 passed, 0 failed.
- JSON keys
natID/slug/has_gender_differencematch the Pokemon HOME living dex template convention, and the"-male"/"-female"slug-suffix gender check matchesPokemonHome_BoxSorterLivingDex::is_viable_for_dex. FRLG'sscan_box_datadoes populatedex_number(National Dex viaSLUGS_TO_NATIONAL_DEX),gender, andshiny, sois_viable_for_dexhas the data it needs. make_living_dex_orderlogic checks out: it never drops Pokemon (template slots + extras always fit unless the overflow error fires, which is reachable: a nearly full box withshiny_dexand no shinies makes every Pokemon an extra, and the non-template slots can be fewer than the Pokemon count). Running it on already-organized boxes yields an empty plan, so it's idempotent.NATIONAL_DEX_SLUGS().at(nat_id - 1)inmake_missing_living_dex_reportis safe because the loader boundsnatIDto 1..386.
No blockers; two minor items below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting the FRLG Box Sorter PR - 9
Helper methods for sorting the living dex
Similar to previous Box Organization helper methods. These will be used in a new Living Dex Sorter program as well as test classes.