Repository navigation
Read audio input formats from the macOS instead of Qt - #1737
Merged
Merged
Conversation
Gin890
changed the title
Gin890
force-pushed
the
mirabox-audio-native-formats
branch
3 times, most recently
from
October 31, 2026 03:25
e2ec15c to
d3d759b
Compare
Gin890
marked this pull request as ready for review
October 31, 2026 03:25
Gin890
requested review from
Mysticial and
pa-devbot
and removed request for
pa-devbot
October 31, 2026 03:26
Qt 6.10 reports every sample rate up to 192 kHz as supported for every audio device. The input format list trusts that, so on macOS a MiraBox defaults to 1ch x 192 kHz, where Qt's macOS audio input delivers no data at all. #1758 brought back the Interleaved Stereo choices, but the silent 192 kHz choice still wins the default. Build the list from the formats the hardware runs in: CoreAudio's physical formats on macOS, the OS device format on Windows and Linux. Keep the device's own sample format and default a MiraBox to R/L. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gin890
force-pushed
the
mirabox-audio-native-formats
branch
from
October 31, 2026 03:36
d3d759b to
6762bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt 6.10 reports every sample rate up to 192 kHz as supported for every audio device on macOS. Since #1711 the input format list trusts Qt's report of supported audio format, on macOS a Mirabox lists all possible audio sample rates.
This PR uses macOS native audio lib CoreAudio to query supported audio formats while keeps the same method on Windows and Linux