Add spaday-based model registry browser by timkpaine · Pull Request #249 · Point72/ccflow

timkpaine · 2026-07-16T15:17:13Z

No description provided.

github-actions · 2026-07-16T15:20:22Z

Test Results

1 files ± 0 1 suites ±0 2m 58s ⏱️ ±0s
1 458 tests +95 1 456 ✅ +95 2 💤 ±0 0 ❌ ±0
1 464 runs +95 1 462 ✅ +95 2 💤 ±0 0 ❌ ±0

Results for commit ddb5625. ± Comparison against base commit bb4ab7e.

This pull request removes 67 and adds 162 tests. Note that renamed tests count towards both.

ccflow.tests.ui.test_cli.TestGetUIArgsParser ‑ test_overrides_positional
ccflow.tests.ui.test_cli.TestGetUIArgsParser ‑ test_parser_composition
ccflow.tests.ui.test_cli.TestGetUIArgsParser ‑ test_viewer_layout_custom_values
ccflow.tests.ui.test_cli.TestGetUIArgsParser ‑ test_viewer_layout_defaults
ccflow.tests.ui.test_model.TestModelConfigViewer ‑ test_init_returns_viewable
ccflow.tests.ui.test_model.TestModelConfigViewer ‑ test_on_model_change_with_description
ccflow.tests.ui.test_model.TestModelConfigViewer ‑ test_on_model_change_with_model
ccflow.tests.ui.test_model.TestModelConfigViewer ‑ test_on_model_change_with_none
ccflow.tests.ui.test_model.TestModelConfigViewer ‑ test_panel_contains_html_pane
ccflow.tests.ui.test_model.TestModelConfigViewer ‑ test_render_dependencies_empty
…

ccflow.tests.ui.panel.test_cli.TestGetUIArgsParser ‑ test_overrides_positional
ccflow.tests.ui.panel.test_cli.TestGetUIArgsParser ‑ test_parser_composition
ccflow.tests.ui.panel.test_cli.TestGetUIArgsParser ‑ test_viewer_layout_custom_values
ccflow.tests.ui.panel.test_cli.TestGetUIArgsParser ‑ test_viewer_layout_defaults
ccflow.tests.ui.panel.test_model.TestModelConfigViewer ‑ test_init_returns_viewable
ccflow.tests.ui.panel.test_model.TestModelConfigViewer ‑ test_on_model_change_with_description
ccflow.tests.ui.panel.test_model.TestModelConfigViewer ‑ test_on_model_change_with_model
ccflow.tests.ui.panel.test_model.TestModelConfigViewer ‑ test_on_model_change_with_none
ccflow.tests.ui.panel.test_model.TestModelConfigViewer ‑ test_panel_contains_html_pane
ccflow.tests.ui.panel.test_model.TestModelConfigViewer ‑ test_render_dependencies_empty
…

♻️ This comment has been updated with latest results.

codecov · 2026-07-16T15:21:06Z

Codecov Report

❌ Patch coverage is 96.45390% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.78%. Comparing base (bb4ab7e) to head (ddb5625).

Files with missing lines	Patch %	Lines
ccflow/tests/ui/spaday/utils.py	65.90%	13 Missing and 2 partials ⚠️
ccflow/ui/panel/cli.py	60.00%	10 Missing ⚠️
ccflow/ui/panel/model.py	95.83%	3 Missing and 2 partials ⚠️
ccflow/ui/spaday/cli.py	94.04%	4 Missing and 1 partial ⚠️
ccflow/ui/spaday/model.py	96.29%	1 Missing and 2 partials ⚠️
ccflow/tests/ui/spaday/test_model.py	99.03%	1 Missing ⚠️
ccflow/ui/panel/registry.py	98.85%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   93.59%   93.78%   +0.18%     
==========================================
  Files         176      190      +14     
  Lines       20613    21499     +886     
  Branches     1361     1410      +49     
==========================================
+ Hits        19292    20162     +870     
- Misses       1048     1062      +14     
- Partials      273      275       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptomecek · 2026-08-25T22:34:56Z

@timkpaine IS this ready for review yet?

timkpaine

dagre rendering a bit messed up, also its global and not model-local so it looks a bit weird

materializing a model collapses the tree, need to fix

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Replace the hand-built wa-tree with spaday-trees, which derives the hierarchy from registry paths and brings its own search box. Add a Dependencies tab rendering the registry dependency DAG with spaday-dagre; clicking a node selects that model, so the graph shares the sidebar's selection state. Registered names are root-relative and leading-slashed, so they are normalized before matching leaf paths. Bridge the tree's color-scheme to the wa-dark page theme and add a dark toggle. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Rename the server bind option from --address to --host. Make the dependency graph model-local: each model's card gets a Dependencies tab showing only what is reachable from that model, with the focused node marked, instead of one global graph in a page-level tab. Models with no dependencies get no tab. Bind the tree's selected_paths to the seeded selection so materializing a model reveals it again after the redirect instead of leaving the tree collapsed. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Label nodes with the full registry path so the hierarchy an entry comes from is visible. Point edges from a dependency to the model that uses it, so the chain reads in dataflow order and the inspected model is the last node. Replace navigate-on-click with a context menu: a pointer event on a node opens a popup naming it, and its Open model action both selects the model and reveals it in the sidebar tree. Each node carries its own menu body with literal actions, because the action DSL cannot build the single-element list the tree's selected_paths needs from a store value. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Materialize a lazy model in place: the button posts to /materialize and refreshes the tree, instead of a form post and a redirect that reloaded the page and collapsed the sidebar. Failures were previously visible only in the server log; the endpoint now returns its error and a toast reports it. Route detail cards with Switch instead of one Show per model, and defer each card to /card so only the visible one is fetched. A 500-model registry drops from 1.6 MiB of tree.json to 129 KiB. Bind the selection to a query parameter, so a model is linkable and back/forward navigate between models, and derive the tree's reveal from it so a deep link expands to the model. Remember the theme with persist. Browse with spaday-trees, badging models that are still configuration, and give the dependency graph full registry paths as labels, edges that point from a dependency to its dependent, and a node context menu in place of navigating on click. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

A leading-slash path resolves against the process-global root registry, so the materialize endpoint could instantiate models outside the registry being served. Only paths the page itself lists are accepted now, and the endpoint requires a JSON object body with a matching content type so it cannot be driven by a cross-origin form post. Also resolve dependency names against every alias in a group rather than only the first, so edges survive when a subregistry is served, and re-check the loaded state when a lazy entry is materialized between the two registry lookups. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

The console script passes no hydra.main() defaults, so a bare invocation left resolve_config_paths to raise ValueError and print a traceback. Route it through argparse instead, so the command exits 2 with its usage message. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

The console script has no hydra.main() defaults to fall back on, so it demanded --config-path even though --config-dir plus --config-name already identifies a usable config. Resolve the config dir the same way load_config does and use it as the root when no --config-path is given, leaving it off the search path so it is not added twice. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Compare the materialize content type case-insensitively, since media types are case-insensitive and an uppercase spelling was rejected with a spurious 415. Skip a lazy registry entry that is neither loaded nor pending, which happens when it is removed between the two lookups and previously reached dependency_edges as None. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

ptomecek

Approved. The spaday registry browser is cleanly structured (cli/registry/model/graph) with matching test coverage — all 86 spaday tests pass locally.

The latest security fix (restricting materialization to the served registry) is correct and important: the content-type + JSON-object + leaf-path allow-list closes the leading-slash root-registry escape and blocks cross-origin form-post CSRF. The dependency alias resolution and lazy re-check race fixes are sound.

Both review nits (case-insensitive content-type, and skipping a lazy entry removed between lookups) were addressed in ddb5625.

Backwards compatible: no released CLI changes ([project.scripts] was empty on main; ccflow-ui-spaday is new, and --address→--host only touches the unreleased spaday CLI), and the old ccflow.ui.model/registry/cli modules remain as compatibility shims re-exporting all public symbols.

timkpaine force-pushed the tkp/spaday branch from c4813cb to 1b314a6 Compare July 16, 2026 17:11

timkpaine force-pushed the tkp/spaday branch from 8030a15 to 61aeef1 Compare August 19, 2026 12:53

timkpaine changed the base branch from main to tkp/lazy-registry August 19, 2026 12:53

timkpaine force-pushed the tkp/lazy-registry branch from 7624af2 to 9a5bcec Compare August 19, 2026 12:55

timkpaine force-pushed the tkp/spaday branch from 61aeef1 to b33ebff Compare August 19, 2026 12:55

timkpaine force-pushed the tkp/lazy-registry branch from 9a5bcec to de7f4da Compare August 19, 2026 20:33

timkpaine force-pushed the tkp/spaday branch 2 times, most recently from 238dc5a to a40c136 Compare August 19, 2026 20:41

timkpaine force-pushed the tkp/lazy-registry branch from de7f4da to 06586d8 Compare August 19, 2026 22:23

timkpaine force-pushed the tkp/spaday branch from a40c136 to 5e28d22 Compare August 19, 2026 22:23

timkpaine force-pushed the tkp/lazy-registry branch from 06586d8 to 03eac9c Compare August 19, 2026 23:06

timkpaine force-pushed the tkp/spaday branch from 5e28d22 to 368502e Compare August 19, 2026 23:06

Base automatically changed from tkp/lazy-registry to main August 19, 2026 23:24

timkpaine force-pushed the tkp/spaday branch from 368502e to bf691e8 Compare August 19, 2026 23:25

timkpaine force-pushed the tkp/spaday branch from bf691e8 to f548c2e Compare August 26, 2026 11:37

timkpaine commented Aug 26, 2026

View reviewed changes

Comment thread ccflow/ui/spaday/cli.py Outdated

timkpaine commented Aug 26, 2026

View reviewed changes

timkpaine added 8 commits September 22, 2026 15:50

Add spaday-based model registry browser

3a4c7ae

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Support lazy registries in Spaday browser

1e18841

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Materialize when navigating

e265a7c

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Update Spaday integration for latest dependencies

5f7a89f

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

Address Spaday review findings

4782d21

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>

timkpaine force-pushed the tkp/spaday branch from 3e6952b to 5197c01 Compare September 22, 2026 20:11

timkpaine force-pushed the tkp/spaday branch from 5197c01 to 7b03470 Compare September 22, 2026 20:17

timkpaine marked this pull request as ready for review September 22, 2026 23:16

timkpaine requested review from feussy, hintse and ptomecek as code owners September 22, 2026 23:16

ptomecek reviewed Sep 25, 2026

View reviewed changes

Comment thread ccflow/ui/spaday/cli.py Outdated

ptomecek reviewed Sep 25, 2026

View reviewed changes

Comment thread ccflow/ui/spaday/registry.py

timkpaine added 3 commits September 25, 2026 17:48

ptomecek approved these changes Sep 25, 2026

View reviewed changes

timkpaine merged commit 249b88d into main Sep 25, 2026
20 checks passed

timkpaine deleted the tkp/spaday branch September 25, 2026 23:35

Navigation Menu

Add spaday-based model registry browser - #249

Add spaday-based model registry browser#249
timkpaine merged 13 commits into
mainfrom
tkp/spaday

timkpaine commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

ptomecek commented Aug 25, 2026

Uh oh!

Uh oh!

timkpaine left a comment

Uh oh!

Uh oh!

Uh oh!

ptomecek left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

timkpaine commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

codecov Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ptomecek commented Aug 25, 2026

Uh oh!

Uh oh!

timkpaine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ptomecek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jul 16, 2026 •

edited

Loading

codecov Bot commented Jul 16, 2026 •

edited

Loading