Conversation
An all-day event ends at 23:59:59.999, but the event stores its end in whole seconds. The full-day check in toJSON compared milliseconds, so it failed and sent the booking as a custom period ending at 23:59:59 with all_day false. Compare the day bounds in seconds instead. Native room bookings also now keep the event all_day flag and timezone, so a 23-hour DST day stays all day. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
app.events.use_bookingson, an All Day room booking did not reserve the full day.The one-hour result in PPT-2804 came from a missing duration. PPT-2810 (
eb9bf26b8) already fixed that ondevelop. One defect remained: the event form builds the all-day range to 23:59:59.999, andCalendarEventstores its end in whole seconds (23:59:59.000).toJSONcompared the day bounds in milliseconds, so the check failed. The event was sent as a custom period withall_day: false, ending at 23:59:59.Fix
CalendarEvent.toJSONcompares the day bounds in seconds. A full day is now sent asall_day: true, from 00:00 to the next 00:00.newBookingFromCalendarEventpasses the eventall_dayflag and timezone toBooking. A 23-hour DST day stays all day, and the booking uses the organiser timezone.Side effects:
custom_all_day) is saved as a normal all-day event when it is next edited.all_day_periodranges do not change.Checks
bunx nx run-many -t test -p common,bookings,events: passbunx nx build workplace: passtoJSONwith an explicit timezone.Recording: PPT-2804-all-day-room-booking.gif (terminal run of the focused tests. There is no local backend.)
Changes made by Claude Opus 5.5 (1M context) in Claude Code.
🤖 Generated with Claude Code