feat(visitor_mailer): notify the host and booker when a visitor booking is created (PPT-2692) - #632
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
…ng is created (PPT-2692) When a visitor booking is created the host can now be emailed, and so can the person who made the booking when that is someone else. Both are off by default and each email also needs its Concierge template to exist. - notify_host_on_booking: the host gets notify_host_booked when they made the booking themselves, or notify_host_delegated when someone booked on their behalf - notify_booker_on_booking: the booker gets notify_booker when they are not the host - notify_booker_on_checkin: the booker also gets a copy of the check-in notification (notify_checkin_booker) - new template fields booked_by_name and booked_by_email; reply-to on the host's delegated email is the booker, and on the booker's emails is the host - event-linked bookings are left to the calendar invitation the host already has - GuestCheckin carries booking_id so the check-in copy can look up the booker Tests 74 to 79 cover the default, the self-booked and delegated cases, event-linked bookings, updates versus creations, and the check-in copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(visitor_mailer): notify the host and booker when a visitor booking is created (PPT-2692)
When a visitor booking is created the host can now be emailed, and so can the person who
made the booking when that is someone else. Both are off by default and each email also
needs its Concierge template to exist.
themselves, or notify_host_delegated when someone booked on their behalf
(notify_checkin_booker)
email is the booker, and on the booker's emails is the host
Tests 74 to 79 cover the default, the self-booked and delegated cases, event-linked
bookings, updates versus creations, and the check-in copy.