feat(place/driver_health): include driver processes running on edges - #628
Merged
Merged
Conversation
) A core node already reports the processes on each edge attached to it, in the same responses we were making, but only the `local` half was being read. So a driver running only on an edge was invisible, and one running on both a node and an edge was reported for the node alone. Now the union of `loaded.local` and every `loaded.edge` entry is walked, and a state is emitted per location a driver runs in, taking memory from `status.local` or `status.edge[edge_id]` as appropriate. This costs no extra requests, a single driver status response covers the node and all of its edges. Edge processes are named `<edge id>.<driver>`. Edges aren't queried directly and the node an edge happens to be attached to isn't part of the path to it, so neither the edge hostname nor the core hostname belongs in the name. Results are deduplicated by name, so an edge reported by more than one core node is counted once. Not yet exercised against a live edge, the spec covers it with fake core nodes. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
camreeves
added a commit
that referenced
this pull request
Sep 24, 2026
…(PPT-2375, PPT-2667) (#631) Visitor mailer changes for HIO (PPT-2375, PPT-2667), tested end to end on hio.uat.placeos.run. Supersedes #629. Mia's commits from #629: - fix(visitor_mailer): refresh the building zone instead of memoising it - fix(visitor_mailer): name the building the visit is in - fix(visitor_mailer): stop emailing visitors removed from the visit - fix(visitor_mailer): email the original host once per reassignment - fix(visitor_mailer): tell a visitor about a change once - fix(visitor_mailer): notify group event registrations of changes - docs(visitor_mailer): document building naming and change coalescing - fix(visitor_mailer): render times in the zone the visit is in - docs(visitor_mailer): document time zone precedence - fix(visitor_mailer): prefer the building time zone for emails On top of #629: - feat(place/driver_health): report driver process health across the cluster (#627) - feat(place/driver_health): include driver processes running on edges (#2) (#628) - fix(place/driver_health): name key without hostname - fix(place/driver_health): return running if no modules expected - feat(place/driver_health): add not running size - fix(public_events): fetch the metadata permission from the staff API (PPT-2247) (#625) - feat(gallagher/parking_approvals): prevent duplicate email sends - feat(occupancy): add occupancy_sensor_failed common setting - feat(gallagher/parking_approvals): send email on manual approval - feat(occupancy): flag if occupancy actions are being ignored - feat(gallagher/parking_approvals): implement lottery system - feat(bookings): hide meeting details on the backend - fix(mulesoft/booking_api): use tmp folder for certs - fix(place/bookings): hide meeting details to strip most information - feat(gallagher/parking_approvals): add email_bcc setting - fix(gallagher/parking_approvals): resolve transient failures - feat(gallagher/parking_approvals): check for car or bike features before notes - fix(cisco/dna_spaces): parse Space Occupancy events - fix(optergy/p864): failure to compile - chore(staff_api.cr): use ingress nginx service as default URI (#630) - feat(visitor_mailer): end time and time zone placeholders (PPT-2667, PPT-2375) - fix(visitor_mailer): event_timezone is the zone abbreviation - fix(visitor_mailer): previous room ignores the zones above the building - fix(visitor_mailer): keep the previous-zone short circuit - fix(visitor_mailer): linked booking invites follow the event path by default - fix(visitor_mailer): cap change_debounce where the invite memory is Co-authored-by: Mia Bennett <mia@chillfox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A core node already reports the processes on each edge attached to it, in the same responses we were making, but only the
localhalf was being read. So a driver running only on an edge was invisible, and one running on both a node and an edge was reported for the node alone.Now the union of
loaded.localand everyloaded.edgeentry is walked, and a state is emitted per location a driver runs in, taking memory fromstatus.localorstatus.edge[edge_id]as appropriate. This costs no extra requests, a single driver status response covers the node and all of its edges.Edge processes are named
<edge id>.<driver>. Edges aren't queried directly and the node an edge happens to be attached to isn't part of the path to it, so neither the edge hostname nor the core hostname belongs in the name. Results are deduplicated by name, so an edge reported by more than one core node is counted once.