Skip to content

feat(visitor_mailer): add previous location fields - #604

Merged
stakach merged 6 commits into
masterfrom
PPT-2375_more_fields
Apr 22, 2026
Merged

stakach merged 6 commits into
masterfrom
PPT-2375_more_fields

Conversation

@chillfox

@chillfox chillfox commented Apr 21, 2026 •

Copy link
Copy Markdown
Contributor

...and minor improvements.

@chillfox
chillfox requested a review from Copilot April 21, 2026 03:00
@chillfox chillfox self-assigned this Apr 21, 2026
@chillfox
chillfox marked this pull request as ready for review April 21, 2026 03:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for including “previous location” information in the visitor booking-changed email payload, so templates can show where a booking used to be before a move.

Changes:

  • Adds previous_room_name and previous_building_name template fields for the booking-changed notification.
  • Resolves previous building/room names from details.previous_zones and passes them into mailer.send_template.
  • Minor refactors/cleanup (zone list accessor usage, block variable naming, rescue style).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread drivers/place/visitor_mailer.cr
Comment thread drivers/place/visitor_mailer.cr
Comment thread drivers/place/visitor_mailer.cr
@chillfox
chillfox marked this pull request as draft April 21, 2026 03:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread drivers/place/visitor_mailer_spec.cr
Comment thread drivers/place/visitor_mailer_spec.cr Outdated
chillfox and others added 2 commits April 21, 2026 14:17
@chillfox
chillfox requested a review from Copilot April 21, 2026 04:49
@chillfox
chillfox marked this pull request as ready for review April 21, 2026 04:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chillfox
chillfox requested review from naqvis and stakach April 21, 2026 05:00

@stakach stakach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach
stakach merged commit 6f4b1aa into master Apr 22, 2026
7 of 9 checks passed
@stakach
stakach deleted the PPT-2375_more_fields branch April 22, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants