fix(ssh): install the remote release runtime under T3CODE_HOME - #4
Merged
Merged
Conversation
The remote runner unpacks the t3 release archive into
$HOME/.t3/runtime/versions, which ignores T3CODE_HOME and lands next
to a server whose home already moved. Derive the runtime directory from
${T3CODE_HOME:-$HOME/.t3} like the other remote scripts, and export the
XDG default so the runner child sees the same home as its launcher.
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upstream commit 13c134c (pingdotgg#11319) added a remote runner that downloads the self-contained t3 release archive and unpacks it into
$HOME/.t3/runtime/versions/<version>. That path ignoresT3CODE_HOME, so a remote with a relocated home gets~/.t3back, and the runtime lands outside the home the server andt3 service installuse.Change
T3_HOME="${T3CODE_HOME:-$HOME/.t3}"and installs under$T3_HOME/runtime/versions. Same rule as the launch, pairing, stop and log scripts from fix(ssh): honor T3CODE_HOME on the remote host #1.T3CODE_HOMEafter resolving it, so the runner child sees the same home as its launcher.The runner part is upstream material, same shape as #1.
Verification
vp test run packages/ssh: 35 passedContext
devwas rebased onto upstream/main (106 new commits, through ae53072). Your three commits sit at the tip. The desktop typecheck error inapps/desktop/src/updates/updatesTestHarness.tsis upstream's, the file is identical there.