Skip to content

PILOT-3280: add the error handler to search_item function - #73

Merged
colorzzr merged 2 commits into
developfrom
PILOT-3280
Jul 13, 2023
Merged

PILOT-3280: add the error handler to search_item function#73
colorzzr merged 2 commits into
developfrom
PILOT-3280

Conversation

@colorzzr

Copy link
Copy Markdown
Member

Summary

the function does not properly handle the error other than 403. to fix this, add a elif to handle the error != 200

JIRA Issues

PILOT-3280

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor or reformatting

Testing

Are there any new or updated tests to validate the changes?

  • Yes
  • No

Test Directions

(Additional instructions for how to run tests or validate functionality if not covered by unit tests)

@colorzzr
colorzzr requested a review from vmoshynskyi July 11, 2023 14:23
@colorzzr colorzzr self-assigned this Jul 11, 2023
@github-actions

github-actions Bot commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
pilotcli.py0290%5–6, 8–12, 15–19, 21–26, 29–37, 40–41
commands
   __init__.py00100% 
   container_registry.py0470%5, 7–10, 13–14, 16, 19–24, 27–33, 36–44, 47–53, 56–65
   dataset.py04844%19, 36–38, 41–48, 50–60, 78–80, 83–91, 93–103, 123, 127
   entry_point.py0810%5, 7, 9–10, 12–25, 28–32, 34, 37–41, 44–46, 49–53, 56–60, 63–67, 70–73, 76–78, 81–84, 87–104, 107, 109–111, 113
   file.py06169%36, 133, 137, 155–156, 198, 280–287, 289, 291, 305–311, 313, 342, 344, 347, 383–389, 392–393, 395–396, 398–410, 412–414, 416, 419–421, 423–425
   kg_resource.py0130%5, 7–9, 12–13, 15, 18–23
   project.py0390%5–6, 8–11, 14–15, 17, 20–23, 31, 39, 48–52, 55–62, 64–74
   use_config.py0130%5, 7–9, 12–13, 15, 18–20, 27–29
   user.py0685%23, 40, 48, 56, 72–73
configs
   __init__.py00100% 
   app_config.py00100% 
   user_config.py01784%44, 53, 96, 106, 113, 117, 121, 125, 129, 133, 137, 141, 145, 149, 153, 157, 161
models
   __init__.py00100% 
   enums.py00100% 
   service_meta_class.py0180%9
   singleton.py00100% 
   upload_form.py0625%30, 42–46
resources
   custom_error.py00100% 
   custom_help.py00100% 
services
   __init__.py00100% 
services/crypto
   __init__.py00100% 
   crypto.py01940%35, 43–47, 49, 59–61, 69–75, 77, 79
services/dataset_manager
   dataset_detail.py02370%42, 44, 61, 68–73, 75–77, 79–88, 90
   dataset_download.py01983%56, 72–73, 84, 96, 98–99, 101–102, 104, 106–108, 116–119, 153, 165
   dataset_list.py0683%37, 43–44, 46–48
   model.py00100% 
services/file_manager
   __init__.py00100% 
   file_list.py01971%29, 48, 50, 57–58, 63–65, 73–76, 78, 84–89
   file_manifests.py09525%19–24, 39–43, 47–48, 51–59, 61, 65–68, 71–75, 77, 81–82, 85–87, 91–92, 95–102, 104, 107, 109–110, 112–113, 115–118, 123–129, 134–139, 142–148, 150–152, 155–161, 163–165, 167–170
   file_tag.py03931%23, 27–31, 33, 36–48, 50–52, 54–55, 59–61, 64–68, 70–73, 75–76
services/file_manager/file_download
   __init__.py00100% 
   download_client.py018717%29–41, 44–45, 47–53, 56–57, 59–60, 69, 71–72, 76–79, 86, 91–94, 96, 98–106, 108, 110, 114–119, 121, 124–125, 128–130, 132–134, 136–137, 139–141, 145–153, 156–161, 165–174, 182–184, 186–193, 195–199, 204–214, 216–217, 220–221, 226–227, 231–236, 240–241, 244–246, 248–259, 263–266, 269–273, 275–277, 279–281, 283–284, 286, 290–292, 294–307, 309
   model.py0187%15
services/file_manager/file_upload
   __init__.py00100% 
   exception.py0175%10
   file_upload.py03081%33–40, 74, 104, 135–136, 140, 145, 177, 185–187, 191, 208, 210, 214, 225–226, 228–230, 308, 311, 315
   models.py0591%23, 41, 147–149
   upload_client.py07557%100–103, 165–167, 181–187, 189–193, 195–207, 209, 253, 256, 260, 262–265, 269–274, 276, 280, 282, 284, 286, 304, 329–330, 335, 339–342, 346, 362, 364–366, 373, 378–379, 381, 383–384, 386–389, 391
   upload_validator.py02452%26–28, 31–36, 39–48, 51–52, 57, 59, 61
services/kg_manager
   kg_resource.py01185%33–34, 36–37, 65–66, 81–82, 87–89
services/logger_services
   __init__.py00100% 
   log_functions.py00100% 
services/output_manager
   __init__.py00100% 
   error_handler.py00100% 
   help_page.py0889%36–37, 46–47, 98–99, 111–112
   message_handler.py05666%23, 45, 50, 65–67, 72, 77, 82, 87, 100, 105, 112, 117, 122, 126, 142, 162, 172, 182, 201, 223–234, 245–250, 252–258, 269, 273–274, 278–279, 281–282, 286, 290, 294
services/project_manager
   __init__.py00100% 
   project.py0683%38, 44–45, 47–49
services/user_authentication
   __init__.py00100% 
   decorator.py01075%29, 32, 51–53, 59–62, 64
   token_manager.py01575%24, 39–40, 71, 74, 81–82, 88–89, 91–94, 96, 101
   user_login_logout.py04265%29–30, 40, 121, 125–131, 133–135, 139–140, 144–151, 153–155, 159–160, 167–172, 174–176, 180–183
   user_set_config.py0947%15–18, 22–24, 26–27
utils
   __init__.py00100% 
   aggregated.py02968%68–70, 72–73, 80–81, 83, 87–90, 92–93, 112–114, 116, 121–128, 130–132
TOTAL2729109060% 

@vmoshynskyi vmoshynskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my suggestions.

Comment thread app/utils/aggregated.py Outdated
Comment thread tests/app/utils/test_aggregated.py Outdated
Comment thread tests/app/utils/test_aggregated.py Outdated

@vmoshynskyi vmoshynskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colorzzr
colorzzr merged commit 70301ab into develop Jul 13, 2023
@vmoshynskyi
vmoshynskyi deleted the PILOT-3280 branch July 13, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants