Pilot 3209: fixup the manifest attaching when resumable upload - #69
Merged
Conversation
Contributor
erikdvlp
approved these changes
Jun 29, 2023
erikdvlp
left a comment
Contributor
There was a problem hiding this comment.
Approved, just one question for your consideration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
there is a bug when use try to resume a upload with the manifest. The manifest will be lost during the resumable upload. To fix this, add the information of manifest into output json. and add manifest attaching logic when resume a upload
JIRA Issues
Pilot 3209
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
add a test to check if manifest function is called