Pilot 2936: add an action to create the cli with mac version - #59
Merged
Conversation
added 15 commits
May 17, 2023 15:10
Contributor
andricDu
reviewed
May 17, 2023
| push-binary-macos: | ||
| needs: [ push-binary-linux ] | ||
| if: ${{ needs.extract-branch-name.outputs.branch == 'main' || needs.extract-branch-name.outputs.branch == 'develop'}} | ||
| runs-on: macos-12 |
Member
Author
There was a problem hiding this comment.
it seems like x64 version. Any concerns on this?
https://github.blog/2023-03-01-github-actions-introducing-faster-github-hosted-x64-macos-runners/
java version is also x64: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#java
andricDu
approved these changes
May 17, 2023
colorzzr
added a commit
that referenced
this pull request
Jun 1, 2023
* update the lineage to use core zone file instead of greenroom * bumpup version * bumpup version to 2.5.0 * fixes versioning * bumpup version * Pilot 2936: add an action to create the cli with mac version (#59) * add new action for create mac binary * add the tag name * add the python and poetry * output the release url in the linux step not in a dedicate step * output the release url in the linux step not in a dedicate step * output the release url in the linux step not in a dedicate step * bumpup version * bumpup version * bumpup version * fixup the upload_url * fixup the upload_url * fixup the upload_url * use correct naming * add back build step * remove the test branch * bumpup version --------- Co-authored-by: zhiren <zzhan@indocresearch.org> * bumpup to next minor * cleanup the code --------- Co-authored-by: zhiren <zzhan@indocresearch.org> Co-authored-by: Dušan Andrić <Dusan.Andric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
now portal supports to download cli with linux and mac version. To allow building latest mac version, the git action will need to run the build on the mac machine.
JIRA Issues
Pilot 2936
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
(Additional instructions for how to run tests or validate functionality if not covered by unit tests)