PILOT-2676: Fix project file listing white page error - #49
Merged
Conversation
Contributor
hugoantunes
suggested changes
Apr 21, 2023
hugoantunes
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test to when self.list_files(paths, zone, page, page_size) returns '' too?
Member
Author
This will be the same response. In the real case, it will still response an empty list and ask for exit |
hugoantunes
approved these changes
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Try to fix the project file listing with the page change error. The file listing with page change always result in a blank page at the end. This is because the check file length, it checks the length of the string which corresponds to the length of the file folder name instead of the number of files and folders.
JIRA Issues
https://indocconsortium.atlassian.net/browse/PILOT-2676
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
Have tested on local for this pagination issue