Skip to content

PILOT-2676: Fix project file listing white page error - #49

Merged
QXgu merged 6 commits into
developfrom
PILOT-2676
May 4, 2023
Merged

PILOT-2676: Fix project file listing white page error#49
QXgu merged 6 commits into
developfrom
PILOT-2676

Conversation

@QXgu

@QXgu QXgu commented Apr 20, 2023

Copy link
Copy Markdown
Member

Summary

Try to fix the project file listing with the page change error. The file listing with page change always result in a blank page at the end. This is because the check file length, it checks the length of the string which corresponds to the length of the file folder name instead of the number of files and folders.

JIRA Issues

https://indocconsortium.atlassian.net/browse/PILOT-2676

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Are there any new or updated tests to validate the changes?

  • Yes
  • No

Test Directions

Have tested on local for this pagination issue

@github-actions

github-actions Bot commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
pilotcli.py0290%5–6, 8–12, 15–19, 21–26, 29–37, 40–41
commands
   __init__.py00100% 
   container_registry.py0470%5, 7–10, 13–14, 16, 19–24, 27–33, 36–44, 47–53, 56–65
   dataset.py04844%19, 36–38, 41–48, 50–60, 78–80, 83–91, 93–103, 123, 127
   entry_point.py01020%5, 7, 9–10, 12–25, 28–39, 41–42, 45–51, 54–56, 59–63, 66–70, 73–77, 80–83, 86–88, 91–94, 97–114, 117, 119–121, 123–129, 131, 133–135, 137
   file.py06168%36, 133, 137, 155–156, 198, 273–280, 282, 284, 298–304, 306, 335, 337, 340, 376–382, 385–386, 388–389, 391–403, 405–407, 409, 412–414, 416–418
   hpc.py01230%5, 7–17, 20–21, 23, 26–29, 36–40, 42–45, 47–49, 51, 53–61, 64–72, 75–84, 87–100, 103–117, 120–132, 134–137, 140–153, 155–157
   kg_resource.py0130%5, 7–9, 12–13, 15, 18–23
   project.py0390%5–6, 8–11, 14–15, 17, 20–23, 31, 39, 48–52, 55–62, 64–74
   use_config.py0130%5, 7–9, 12–13, 15, 18–20, 27–29
   user.py0300%5, 7–9, 12–15, 18–19, 21, 42–48, 50, 52, 55–56, 58, 61–62, 71–75
configs
   __init__.py00100% 
   app_config.py00100% 
   user_config.py01579%49, 59, 63, 67, 71, 75, 79, 83, 87, 91, 95, 99, 103, 107, 111
models
   __init__.py00100% 
   convert_type.py080%5, 7, 10–15
   service_meta_class.py0280%9, 16
   singleton.py00100% 
   upload_form.py02661%10, 25, 29, 33, 37, 41, 45, 49, 53, 57, 61, 65, 69, 73, 77, 81, 85, 89, 93, 97, 122, 134–138
resources
   custom_error.py00100% 
   custom_help.py00100% 
services
   __init__.py00100% 
services/crypto
   __init__.py00100% 
   crypto.py01940%35, 43–47, 49, 59–61, 69–75, 77, 79
services/dataset_manager
   dataset_detail.py02370%42, 44, 61, 68–73, 75–77, 79–88, 90
   dataset_download.py07441%50, 54, 58–59, 64–70, 73–74, 76–77, 80–85, 87–88, 92–97, 99, 103–107, 111–113, 115–116, 118–121, 129–132, 135–137, 139–141, 143–144, 146–148, 152–159, 161, 167–171, 173
   dataset_list.py0683%37, 43–44, 46–48
   model.py0187%15
services/file_manager
   __init__.py00100% 
   file_list.py01971%29, 48, 50, 57–58, 63–65, 73–76, 78, 84–89
   file_manifests.py09525%19–24, 39–43, 47–48, 51–59, 61, 65–68, 71–75, 77, 81–82, 85–87, 91–92, 95–102, 104, 107, 109–110, 112–113, 115–118, 123–129, 134–139, 142–148, 150–152, 155–161, 163–165, 167–170
   file_tag.py03931%23, 27–31, 33, 36–48, 50–52, 54–55, 59–61, 64–68, 70–73, 75–76
services/file_manager/file_download
   __init__.py00100% 
   download_client.py018717%29–41, 44–45, 47–53, 56–57, 59–60, 69, 71–72, 76–79, 86, 91–94, 96, 98–106, 108, 110, 114–119, 121, 124–125, 128–130, 132–134, 136–137, 139–141, 145–153, 156–161, 165–174, 182–184, 186–193, 195–199, 204–214, 216–217, 220–221, 226–227, 231–236, 240–241, 244–246, 248–259, 263–266, 269–273, 275–277, 279–281, 283–284, 286, 290–292, 294–307, 309
   model.py0187%15
services/file_manager/file_upload
   __init__.py00100% 
   exception.py0175%10
   file_upload.py03081%33–40, 74, 104, 135–136, 140, 145, 175, 183–185, 189, 206, 208, 212, 223–224, 226–228, 306, 309, 313
   models.py0591%23, 41, 147–149
   upload_client.py07556%98–101, 163–165, 179–185, 187–191, 193–205, 207, 249, 252, 256, 258–261, 265–270, 272, 276, 278, 280, 282, 300, 325–326, 331, 335–338, 342, 358, 360–362, 369, 374–375, 377, 379–380, 382–385, 387
   upload_validator.py02452%26–28, 31–36, 39–48, 51–52, 57, 59, 61
services/hpc_manager
   hpc_auth.py00100% 
   hpc_cluster.py06832%34–37, 39–40, 42, 46–58, 60–64, 66–67, 72–74, 76–77, 81–93, 95–99, 101–102, 106–118, 120–121, 123
services/kg_manager
   kg_resource.py01185%33–34, 36–37, 65–66, 81–82, 87–89
services/logger_services
   __init__.py00100% 
   log_functions.py00100% 
services/output_manager
   __init__.py00100% 
   error_handler.py0198%104
   help_page.py01286%36–37, 46–47, 59–60, 106–107, 116–117, 129–130
   message_handler.py06459%17–22, 27, 32, 37, 47, 52–54, 59, 64, 69, 74, 87, 92, 99, 104, 109, 113, 129, 149, 159, 169, 188, 196, 210–221, 232–237, 239–245, 256, 260–261, 265–266, 268–269, 273, 277, 281
   response_handler.py0530%5–6, 9–12, 14–15, 17–21, 23–24, 26–34, 36–39, 42–45, 47–48, 50–56, 58–59, 61–63, 65–68, 71–73
services/project_manager
   __init__.py00100% 
   project.py0683%38, 44–45, 47–49
services/user_authentication
   __init__.py00100% 
   decorator.py01367%29, 32, 49–53, 55, 59–62, 64
   token_manager.py02157%25, 28–30, 33, 36–37, 40–41, 61, 65, 69–70, 76–77, 79–82, 84–85
   user_login_logout.py04365%40–43, 114, 118–124, 126–128, 132–133, 137–144, 146–148, 152–153, 160–165, 167–169, 173–176
   user_set_config.py0947%15–18, 22–24, 26–27
utils
   __init__.py00100% 
   aggregated.py03166%22, 46, 71–73, 75–76, 83–84, 86, 90–93, 95–96, 115–117, 119, 124–131, 133–135
TOTAL3070148751% 

@QXgu
QXgu requested a review from hugoantunes April 21, 2023 14:26

@hugoantunes hugoantunes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to when self.list_files(paths, zone, page, page_size) returns '' too?

@QXgu

QXgu commented Apr 21, 2023

Copy link
Copy Markdown
Member Author

Can you add a test to when self.list_files(paths, zone, page, page_size) returns '' too?

This will be the same response. In the real case, it will still response an empty list and ask for exit

@QXgu
QXgu requested a review from hugoantunes April 24, 2023 14:56
@QXgu
QXgu merged commit 3db14e1 into develop May 4, 2023
@andricDu
andricDu deleted the PILOT-2676 branch May 16, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants