Skip to content

PILOT-2677: Fix the error message error when download empty folder - #41

Merged
QXgu merged 1 commit into
developfrom
PILOT-2677
Apr 18, 2023
Merged

PILOT-2677: Fix the error message error when download empty folder#41
QXgu merged 1 commit into
developfrom
PILOT-2677

Conversation

@QXgu

@QXgu QXgu commented Apr 12, 2023

Copy link
Copy Markdown
Member

Summary

Fix the error message error when download empty folder. In cli when user download the empty folder the error message used to show that the file cannot be save to local drive. This is because the error message validation during download preparation in cli is not correct. Now fix the error handling

JIRA Issues

https://indocconsortium.atlassian.net/browse/PILOT-2677

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Are there any new or updated tests to validate the changes?

  • Yes
  • No

Test Directions

Have tested on local, the error message now shows correctly

@github-actions

Copy link
Copy Markdown
Contributor

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
pilotcli.py0290%5–6, 8–12, 15–19, 21–26, 29–37, 40–41
commands
   __init__.py00100% 
   container_registry.py0470%5, 7–10, 13–14, 16, 19–24, 27–33, 36–44, 47–53, 56–65
   dataset.py0860%5–6, 8–13, 16–17, 19, 22–25, 34–38, 41–48, 50–60, 63–67, 76–80, 83–91, 93–103, 106–109, 117–127, 129–130
   entry_point.py01000%5, 7, 9–10, 12–24, 27–38, 40–41, 44–50, 53–55, 58–62, 65–69, 72–76, 79–82, 85–87, 90–93, 96–112, 115, 117–119, 121–127, 129, 131–133, 135
   file.py01890%5, 7, 9–28, 31–32, 34, 37–40, 49, 58, 66, 74, 82, 89, 97, 105, 113, 121, 129–130, 133–145, 147, 149, 151–152, 156–157, 159–160, 162–165, 175–179, 181, 183–186, 188, 192–193, 201, 213–216, 218, 220–221, 224, 226–234, 237–238, 241–242, 245–255, 257, 259, 263–264, 267, 270–279, 281, 284–286, 294–296, 305–315, 317, 320–323, 331, 339, 348–357, 360–361, 363–364, 366–378, 380–382, 384, 387–389, 391–393
   hpc.py01230%5, 7–17, 20–21, 23, 26–29, 36–40, 42–45, 47–49, 51, 53–61, 64–72, 75–84, 87–100, 103–117, 120–132, 134–137, 140–153, 155–157
   kg_resource.py0130%5, 7–9, 12–13, 15, 18–23
   project.py0390%5–6, 8–11, 14–15, 17, 20–23, 31, 39, 48–52, 55–62, 64–74
   use_config.py0130%5, 7–9, 12–13, 15, 18–20, 27–29
   user.py0300%5, 7–9, 12–15, 18–19, 21, 42–48, 50, 52, 55–56, 58, 61–62, 71–75
configs
   __init__.py00100% 
   app_config.py00100% 
   user_config.py01579%49, 59, 63, 67, 71, 75, 79, 83, 87, 91, 95, 99, 103, 107, 111
models
   __init__.py00100% 
   convert_type.py080%5, 7, 10–15
   service_meta_class.py0280%9, 16
   singleton.py00100% 
   upload_form.py04153%16, 31, 35, 39, 43, 47, 51, 55, 59, 63, 67, 71, 75, 79, 83, 87, 91, 95, 99, 103, 132–133, 141–144, 146–147, 149, 152–153, 155, 164, 192, 205–211
resources
   custom_error.py00100% 
services
   __init__.py00100% 
services/crypto
   __init__.py00100% 
   crypto.py01940%35, 43–47, 49, 59–61, 69–75, 77, 79
services/dataset_manager
   dataset_detail.py02370%42, 44, 61, 68–73, 75–77, 79–88, 90
   dataset_list.py0683%37, 43–44, 46–48
services/file_manager
   __init__.py00100% 
   file_lineage.py0741%13–14, 23, 26–28, 30
   file_list.py0660%5–7, 9–17, 20–21, 23–29, 31–34, 37, 45–60, 62–65, 67, 69–75, 77–88
   file_manifests.py01280%5, 7, 9–15, 18–24, 27, 30–32, 34–35, 37–43, 45–48, 51–59, 61, 63–68, 71–75, 77, 79–82, 85–87, 89–92, 95–102, 104, 106–107, 109–110, 112–113, 115–118, 120–121, 123–129, 131–132, 134–139, 141–148, 150–152, 154–161, 163–165, 167–170
   file_tag.py0570%5, 7, 9–15, 18–20, 22–23, 25–31, 33, 35–48, 50–52, 54–55, 57–61, 64–68, 70–73, 75–76
services/file_manager/file_download
   __init__.py00100% 
   download_client.py02260%5–7, 9–12, 14–22, 24, 27–41, 43–45, 47–53, 55–57, 59–60, 62, 69, 71–72, 74–79, 86, 91–94, 96, 98–106, 108, 110, 112–119, 121, 123–125, 127–130, 132–134, 136–137, 139–141, 143, 145–153, 155–161, 163–174, 182–184, 186–193, 195–199, 201–202, 204–214, 216–217, 220–221, 226–227, 231–236, 240–241, 243–246, 248–259, 261–266, 269–273, 275–277, 279–281, 283–284, 286, 288–292, 294–307, 309
   model.py080%5, 8–12, 14–15
services/file_manager/file_upload
   __init__.py00100% 
   exception.py0175%10
   file_upload.py06937%28–35, 92, 97, 100, 112–116, 119–125, 127, 131–138, 140–141, 143, 145–147, 149–150, 152, 165, 168, 172–173, 175–178, 182, 190–193, 196, 200, 202–203, 205–207, 209–214, 216–217
   models.py0492%23, 106–108
   upload_client.py09945%99–102, 122–126, 138–140, 143–146, 156, 158, 175–176, 179, 189–200, 202–214, 216, 232, 235, 239, 241–244, 248–253, 255, 259, 261, 263, 265, 283, 308–309, 314, 318–321, 325, 341–343, 345–347, 356, 361–362, 364, 366–367, 369–372, 374, 388–394, 404
   upload_validator.py0530%5, 7–12, 15–24, 26–29, 32–34, 38–42, 44–54, 56–58, 60–69
services/hpc_manager
   hpc_auth.py00100% 
   hpc_cluster.py06832%34–37, 39–40, 42, 46–58, 60–64, 66–67, 72–74, 76–77, 81–93, 95–99, 101–102, 106–118, 120–121, 123
services/kg_manager
   kg_resource.py01185%33–34, 36–37, 65–66, 81–82, 87–89
services/logger_services
   __init__.py00100% 
   log_functions.py0284%9–10
services/output_manager
   __init__.py00100% 
   error_handler.py0495%86–88, 102
   help_page.py0900%5, 7, 9–14, 16, 19–23, 26–28, 31–32, 35–37, 40–42, 45–47, 50–55, 58–60, 63–82, 85–87, 90–101, 104–106, 109–111, 114–116, 119–124, 127–129
   message_handler.py06955%17–22, 27, 32, 37, 47, 52–54, 59, 64, 69, 74, 82, 87, 92, 99, 104, 109, 113, 129, 134, 139, 144, 154, 159, 164, 183, 187, 191, 205–216, 227–232, 234–240, 251, 255–256, 260–261, 263–264, 268, 272, 276
   response_handler.py0530%5–6, 9–12, 14–15, 17–21, 23–24, 26–34, 36–39, 42–45, 47–48, 50–56, 58–59, 61–63, 65–68, 71–73
services/project_manager
   __init__.py00100% 
   project.py0683%38, 44–45, 47–49
services/user_authentication
   __init__.py00100% 
   decorator.py01367%29, 32, 49–53, 55, 59–62, 64
   token_manager.py02157%25, 28–30, 33, 36–37, 40–41, 61, 65, 69–70, 76–77, 79–82, 84–85
   user_login_logout.py04365%40–43, 114, 118–124, 126–128, 132–133, 137–144, 146–148, 152–153, 160–165, 167–169, 173–176
   user_set_config.py0947%15–18, 22–24, 26–27
utils
   __init__.py00100% 
   aggregated.py04749%22, 46, 62–73, 75–77, 81–84, 86, 90–93, 95–96, 102–104, 106, 115–117, 119, 124–131, 133–135
TOTAL2913193733% 

@QXgu
QXgu requested a review from erikdvlp April 12, 2023 01:59
@QXgu
QXgu merged commit 8f9d3b5 into develop Apr 18, 2023
@andricDu
andricDu deleted the PILOT-2677 branch May 16, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants