Pilot 4952: Update cli listing command to allow user list specific files/folders under given root level folder - #135
Merged
Merged
Conversation
added 14 commits
March 21, 2024 17:01
added 2 commits
April 5, 2024 16:45
Contributor
colorzzr
requested review from
Samantha77 and
erikdvlp
and removed request for
erikdvlp
April 23, 2024 15:12
Samantha77
reviewed
Apr 25, 2024
| folder_name = os.path.join(temp_paths[1], temp_paths[2]) | ||
| folder_name = temp_paths[2] | ||
| else: | ||
| SrvErrorHandler.customized_handle(ECustomizedError.INVALID_NAMEFOLDER, True) |
Member
There was a problem hiding this comment.
We may want to change the error message to reflect invlid folder structure for either name folder or shared folder
Samantha77
requested changes
Apr 25, 2024
Samantha77
left a comment
Member
There was a problem hiding this comment.
Needs explicit error message for folder structure issue
Member
Author
Thanks for catching that! |
Samantha77
approved these changes
Apr 25, 2024
andricDu
pushed a commit
that referenced
this pull request
May 23, 2024
…les/folders under given root level folder (#135) * add [p] prefix for project folder when listing items under project * group itemprefix class with itemtype class * add double quotation when item name contains space * change enum type PROJECTFOLDER to SHAREDFOLDER * replace PROJECTFOLDER with SHAREDFOLDER * fixup test cases * fixup logic for different prefix * add prefix for name folder * bump up version to 3.0.0 * fixup test cases * fixup test cases * replace hardcoded string with enum value in test cases * remove the reference of project_folder * fixup test cases * update error message with new top level folder structure --------- Co-authored-by: zhiren <zzhan@indocresearch.org> Former-commit-id: 61f8a8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
We used to list project folder together with user name folder. After this refactory, we would like to list them in different path, “shared” and “users”. Because there is no project folder concept in pilot, we will remove the [p] prefix while listing shared folders as well.
Implementation Detail
While listing items, user can use follow command to list items under shared folder or name folder:
Update help info based on above changes
Outcome
After refactor cli, user can list items seperately. When listing under project code directly. only shared and users are visible.
JIRA Issues
Pilot 4952
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
update old test cases