PILOT-4152: Update cli logic to fit dynamic chunk size when uploading - #112
Merged
Conversation
hugoantunes
marked this pull request as ready for review
November 30, 2023 12:56
Contributor
colorzzr
reviewed
Nov 30, 2023
colorzzr
left a comment
Member
There was a problem hiding this comment.
Hey @hugoantunes! Please check the comments below when you have time thx!
colorzzr
approved these changes
Nov 30, 2023
| while True: | ||
| chunk = f.read(self.chunk_size) | ||
| chunk_etag = file_object.uploaded_chunks.get(str(count + 1)) | ||
| chunk = file_object.uploaded_chunks.get(str(count + 1)) |
Member
There was a problem hiding this comment.
can you also add the default as .get(str(count + 1), {}). because if we reach the unfinished chunks, the variable chunk will be None and line 305, 306 will give a error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://indocconsortium.atlassian.net/browse/PILOT-4152
Type of Change
Please delete options that are not relevant.
Testing
Are there any new or updated tests to validate the changes?
Test Directions
N/A