docs: Arm 3 (Fix) design — wire mass appliers + audit-grade safety + OWN gap - #1
Conversation
…OWN gap Grounds the fix arm in the real STS run (72569 findings): 85% come from analyzers shipping code fixes, so we wire roslynator fix / dotnet format rather than build an engine. Documents the off-the-shelf landscape (appliers vs OpenRewrite/Copilot-Autofix + why they don't fit), the risk-tier gate, the safety contract (dry-run -> diff -> re-audit no-new-findings -> tier gate), the OWN001/OWN014 bespoke fixer, the MSBuild build-wall + fix-spike, and a CI/Linux-native first slice. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LLHz4cevQyXHKZnjzCqhoa
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LLHz4cevQyXHKZnjzCqhoa
The audit-grade wrapper from docs/fix-arm.md §4, end to end on IDISP001: select -> dry-run -> diff -> apply -> re-audit -> assert no new findings -> tier gate. We don't ship a fix engine; roslynator fix / dotnet format are the appliers behind a pluggable interface (Replay adapters for CI fixtures, real Roslynator/DotnetFormat/ScriptReaudit adapters for the .NET stand). - fixarm/tiers.py risk tiers T1 auto / T2 review / T3 unfixable / T4 bespoke - fixarm/orchestrate.py select, diff two audit runs, no-new-findings gate, ledger - fixarm/appliers.py Replay* (Linux) + Roslynator/DotnetFormat/ScriptReaudit (stand) - fixarm/cli.py run a fixture through the wrapper - fixtures + tests golden before/after; 6/6 on bare python3 Crux test: a fix that removes the target but introduces a new finding is rejected, never committed. CI/Linux-native; run-over-STS stays Windows-bound. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LLHz4cevQyXHKZnjzCqhoa
📝 WalkthroughWalkthroughThis PR adds the fix-arm documentation, tiering rules, orchestration wrapper, replay and real applier adapters, a CLI entrypoint, IDISP001 fixtures, and orchestration tests. ChangesFix arm workflow
Sequence Diagram(s)sequenceDiagram
participant fixarm_cli_main as "fixarm.cli.main"
participant run_fix as "run_fix"
participant ReplayApplier as "ReplayApplier"
participant ReplayReaudit as "ReplayReaudit"
fixarm_cli_main->>fixarm_cli_main: load before.findings.json
fixarm_cli_main->>fixarm_cli_main: seed temporary workdir
fixarm_cli_main->>run_fix: run_fix(before, workdir, rule, ReplayApplier, ReplayReaudit)
run_fix->>ReplayApplier: dry_run(workdir, rule)
run_fix->>ReplayApplier: apply(workdir, rule)
run_fix->>ReplayReaudit: load after.findings.json
ReplayReaudit-->>run_fix: parsed findings
run_fix-->>fixarm_cli_main: FixResult and ledger()
fixarm_cli_main->>fixarm_cli_main: print ledger and rejection details
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a7c984e38
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if introduced: | ||
| return FixResult(rule, REJECTED, tier, gate, targeted_removed, introduced, | ||
| diff, len(selected)) |
There was a problem hiding this comment.
When the real applier introduces a new finding, this path returns REJECTED after applier.apply() has already mutated workdir, but nothing rolls the checkout back. On the Windows stand this leaves the rejected patch in the target tree, so a later rule run or a manual commit can include the regression even though the ledger says it was rejected/never committed; please restore the tree before returning REJECTED or apply in a disposable worktree.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex Fixed in 56ec0db. Added an Applier.revert hook; run_fix now restores the worktree on every non-success path — REJECTED, NO_EFFECT, and a re-audit that throws (Replay restores before/, real adapters do git checkout -- . + git clean -fd). FixResult.reverted records it in the ledger. New test: test_regression_is_rejected_and_tree_reverted asserts the rejected patch is gone and the file is back to its before/ state.
Generated by Claude Code
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
| """Identity for set-diffing two audit runs. Mirrors the audit's own | ||
| matching: same rule + same basename + line within tolerance. With | ||
| line_tol>0 the line is bucketed so a fix that shifts lines still matches.""" | ||
| ln = self.line if line_tol <= 0 else self.line // (line_tol + 1) |
There was a problem hiding this comment.
When --line-tol is used, bucketing with line // (tol + 1) does not mean “within tolerance”: for example, with line_tol=1, the same finding moving from line 1 to line 2 gets different keys and is reported as removed plus introduced. Any valid fix that shifts a diagnostic across a bucket boundary will be rejected as a new finding despite being within the configured tolerance; compare line distances during matching instead of hashing lines into buckets.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex Fixed in 56ec0db. Replaced the line // (line_tol + 1) bucketing with true within-distance matching: within each (rule, basename) group, before/after findings are matched greedily by absolute line distance ≤ line_tol, so a diagnostic that shifts by ≤ tol is the same site, not removed + introduced. Test: test_line_tolerance_matches_within_distance (covers the line 11→12, tol=1 boundary case).
Generated by Claude Code
There was a problem hiding this comment.
To use Codex here, create an environment for this repo.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@fix/fixarm/appliers.py`:
- Around line 59-63: The apply method in Applier only copies the after_dir
overlay, so files present only in before_dir are never removed from workdir and
the replayed tree can drift from dry_run() results. Update Applier.apply to
reconcile deletions by identifying paths that exist in before_dir but not
after_dir and removing them from workdir before or during the copy loop, while
preserving the existing copy behavior for files from _walk(self.after_dir).
In `@fix/fixarm/cli.py`:
- Around line 26-34: The seeded temporary workspace created by _seed_workdir()
is never cleaned up, so repeated runs leak temp directories. Update main() to
track the directory returned by _seed_workdir() and remove it in a finally block
after the fixture run completes, ensuring cleanup happens even on errors. Use
the existing _seed_workdir() and main() flow to locate where the temp tree is
created and where teardown should be added.
In `@fix/fixarm/orchestrate.py`:
- Around line 32-37: The line tolerance logic in Finding.key() is using bucketed
division, which does not actually preserve “within tolerance” matching and can
split nearby lines into different identities. Update the diffing flow in
Finding.key() and diff_findings() so findings are compared within each (rule,
basename) group using absolute line-distance checks against line_tol rather than
encoding the line into the key. Ensure the matching logic keeps close lines
grouped together without fabricating introduced findings at bucket boundaries.
- Around line 94-96: The non-OK apply paths in the fix-arm flow leave the
working tree mutated, so make the apply operation disposable or add rollback to
the Applier path. Update the orchestration around the apply/audit logic in
orchestrate.py so that the REJECTED and NO_EFFECT branches, plus any re-audit
failure after apply, restore workdir before returning a FixResult. Use the
existing status symbols OK, REJECTED, and NO_EFFECT to ensure every non-success
exit from the apply flow triggers cleanup.
In `@fix/README.md`:
- Around line 7-9: The README snippet is using a bare fenced code block, which
triggers markdownlint MD040 because the content is shell syntax. Update the
fenced block around the pipeline in README.md to use a Bash language tag, and
keep the existing content under the same block so the shell command is clearly
identified. Use the fenced snippet near the select(rule) → dry-run → diff →
apply → re-audit → assert NO new findings → tier gate text to locate it.
- Around line 13-16: The README demo command is not runnable from the repo root
because the module path for fixarm is unresolved; update the documented command
in the README snippet to use a root-compatible invocation, or explicitly include
the package path setup needed to find fixarm from the checkout root. Refer to
the demo command example in the README and make sure the instructions clearly
work without requiring the user to manually cd into fix/ first.
In `@fix/tests/test_orchestrate.py`:
- Around line 42-54: The `_run` helper in test_orchestrate leaks the temporary
workdir created by `_workdir()` because the `finally` block is a no-op and the
comment about OS cleanup is incorrect. Update `_run` to guarantee cleanup of
`wd` after `run_fix` completes, either by deleting the directory in the
`finally` path or by turning `_run` into a context manager so callers can still
inspect the tree before it is removed. Keep the fix localized to `_run`,
`_workdir`, and the `tempfile.mkdtemp()`-backed workdir handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 00eb3550-50c0-4eb1-a044-3577968830ea
📒 Files selected for processing (19)
.gitignorePLAN.mdREADME.mddocs/fix-arm.mdfix/README.mdfix/fixarm/__init__.pyfix/fixarm/appliers.pyfix/fixarm/cli.pyfix/fixarm/orchestrate.pyfix/fixarm/tiers.pyfix/fixtures/idisp001-clean/after.findings.jsonfix/fixtures/idisp001-clean/after/Core/Mail.csfix/fixtures/idisp001-clean/before.findings.jsonfix/fixtures/idisp001-clean/before/Core/Mail.csfix/fixtures/idisp001-regress/after.findings.jsonfix/fixtures/idisp001-regress/after/Core/Mail.csfix/fixtures/idisp001-regress/before.findings.jsonfix/fixtures/idisp001-regress/before/Core/Mail.csfix/tests/test_orchestrate.py
| def apply(self, workdir: str, rule: str) -> None: | ||
| for rel in _walk(self.after_dir): | ||
| dst = os.path.join(workdir, rel) | ||
| os.makedirs(os.path.dirname(dst), exist_ok=True) | ||
| shutil.copy2(os.path.join(self.after_dir, rel), dst) |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Replay apply cannot model file deletions.
dry_run() diffs the union of the before/ and after/ trees, so fixtures can represent removed files, but apply() only overlays after/. Files that exist only in before/ stay in workdir, so the replayed tree can diverge from the recorded after.findings.json.
Suggested fix
def apply(self, workdir: str, rule: str) -> None:
- for rel in _walk(self.after_dir):
+ before_files = set(_walk(self.before_dir))
+ after_files = set(_walk(self.after_dir))
+ for rel in before_files - after_files:
+ stale = os.path.join(workdir, rel)
+ if os.path.exists(stale):
+ os.remove(stale)
+ for rel in sorted(after_files):
dst = os.path.join(workdir, rel)
os.makedirs(os.path.dirname(dst), exist_ok=True)
shutil.copy2(os.path.join(self.after_dir, rel), dst)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| def apply(self, workdir: str, rule: str) -> None: | |
| for rel in _walk(self.after_dir): | |
| dst = os.path.join(workdir, rel) | |
| os.makedirs(os.path.dirname(dst), exist_ok=True) | |
| shutil.copy2(os.path.join(self.after_dir, rel), dst) | |
| def apply(self, workdir: str, rule: str) -> None: | |
| before_files = set(_walk(self.before_dir)) | |
| after_files = set(_walk(self.after_dir)) | |
| for rel in before_files - after_files: | |
| stale = os.path.join(workdir, rel) | |
| if os.path.exists(stale): | |
| os.remove(stale) | |
| for rel in sorted(after_files): | |
| dst = os.path.join(workdir, rel) | |
| os.makedirs(os.path.dirname(dst), exist_ok=True) | |
| shutil.copy2(os.path.join(self.after_dir, rel), dst) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@fix/fixarm/appliers.py` around lines 59 - 63, The apply method in Applier
only copies the after_dir overlay, so files present only in before_dir are never
removed from workdir and the replayed tree can drift from dry_run() results.
Update Applier.apply to reconcile deletions by identifying paths that exist in
before_dir but not after_dir and removing them from workdir before or during the
copy loop, while preserving the existing copy behavior for files from
_walk(self.after_dir).
There was a problem hiding this comment.
@coderabbitai Applied in 56ec0db. ReplayApplier.apply now removes before-only files before overlaying after/, so a fix that deletes a file is modelled and the replayed tree matches after.findings.json. The same reconciliation backs the new revert.
Generated by Claude Code
| def _seed_workdir(before_dir: str) -> str: | ||
| d = tempfile.mkdtemp(prefix="fixarm-") | ||
| for dp, _, names in os.walk(before_dir): | ||
| for n in names: | ||
| full = os.path.join(dp, n) | ||
| dst = os.path.join(d, os.path.relpath(full, before_dir)) | ||
| os.makedirs(os.path.dirname(dst), exist_ok=True) | ||
| shutil.copy2(full, dst) | ||
| return d |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Clean up the seeded temp workspace.
_seed_workdir() creates a fresh mkdtemp(), but main() never removes it. Repeated fixture runs will leak temp trees in CI and local dev.
Suggested fix
- before = load_findings(os.path.join(args.fixture, "before.findings.json"))
- wd = _seed_workdir(os.path.join(args.fixture, "before"))
- res = run_fix(
- before=before, workdir=wd, rule=args.rule,
- applier=ReplayApplier(args.fixture),
- reaudit=ReplayReaudit(os.path.join(args.fixture, "after.findings.json")),
- line_tol=args.line_tol,
- )
-
- print(json.dumps(res.ledger(), indent=2))
- if res.status == REJECTED:
- print(f"\nREJECTED — fix introduced {len(res.introduced)} new finding(s):", file=sys.stderr)
- for f in res.introduced:
- print(f" + {f.rule} {f.path}:{f.line} {f.message}", file=sys.stderr)
- elif res.status == OK and (args.show_diff or res.gate != "auto-commit"):
- print(f"\n--- reviewable patch (gate: {res.gate}) ---\n{res.diff}")
-
- return {OK: 0, NO_OP: 0, UNFIXABLE: 0, REJECTED: 2, NO_EFFECT: 3}.get(res.status, 0)
+ before = load_findings(os.path.join(args.fixture, "before.findings.json"))
+ wd = _seed_workdir(os.path.join(args.fixture, "before"))
+ try:
+ res = run_fix(
+ before=before, workdir=wd, rule=args.rule,
+ applier=ReplayApplier(args.fixture),
+ reaudit=ReplayReaudit(os.path.join(args.fixture, "after.findings.json")),
+ line_tol=args.line_tol,
+ )
+
+ print(json.dumps(res.ledger(), indent=2))
+ if res.status == REJECTED:
+ print(f"\nREJECTED — fix introduced {len(res.introduced)} new finding(s):", file=sys.stderr)
+ for f in res.introduced:
+ print(f" + {f.rule} {f.path}:{f.line} {f.message}", file=sys.stderr)
+ elif res.status == OK and (args.show_diff or res.gate != "auto-commit"):
+ print(f"\n--- reviewable patch (gate: {res.gate}) ---\n{res.diff}")
+
+ return {OK: 0, NO_OP: 0, UNFIXABLE: 0, REJECTED: 2, NO_EFFECT: 3}.get(res.status, 0)
+ finally:
+ shutil.rmtree(wd, ignore_errors=True)Also applies to: 45-62
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@fix/fixarm/cli.py` around lines 26 - 34, The seeded temporary workspace
created by _seed_workdir() is never cleaned up, so repeated runs leak temp
directories. Update main() to track the directory returned by _seed_workdir()
and remove it in a finally block after the fixture run completes, ensuring
cleanup happens even on errors. Use the existing _seed_workdir() and main() flow
to locate where the temp tree is created and where teardown should be added.
There was a problem hiding this comment.
@coderabbitai Fixed in 56ec0db. main() now seeds the workdir inside a try and shutil.rmtrees it in finally, so repeated runs don't leak temp trees.
Generated by Claude Code
There was a problem hiding this comment.
@PhysShell, thanks — that addresses the temp workspace leak cleanly.
| OK = "ok" # fix applied, no regression; gate decides commit vs review | ||
| REJECTED = "rejected" # fix introduced new findings -> reverted, never committed | ||
| NO_EFFECT = "no-effect" # applier ran but the targeted finding survived |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Non-OK apply paths leave the worktree mutated.
After Line 150, the REJECTED and NO_EFFECT branches only return a FixResult; nothing restores workdir. A regressing or ineffective fix can therefore leak into later steps if the caller reuses the same tree. Apply into a disposable copy, or add a rollback hook to Applier and invoke it on every post-apply non-success path, including re-audit failures. This contradicts the documented fix-arm safety flow.
Also applies to: 149-162
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@fix/fixarm/orchestrate.py` around lines 94 - 96, The non-OK apply paths in
the fix-arm flow leave the working tree mutated, so make the apply operation
disposable or add rollback to the Applier path. Update the orchestration around
the apply/audit logic in orchestrate.py so that the REJECTED and NO_EFFECT
branches, plus any re-audit failure after apply, restore workdir before
returning a FixResult. Use the existing status symbols OK, REJECTED, and
NO_EFFECT to ensure every non-success exit from the apply flow triggers cleanup.
There was a problem hiding this comment.
@coderabbitai Fixed in 56ec0db. The REJECTED and NO_EFFECT branches (and a throwing re-audit) now revert the tree via a new Applier.revert hook before returning; FixResult.reverted surfaces it in the ledger. This restores the documented §4 safety flow. Real adapters revert with git checkout+clean; the Replay adapter restores before/.
Generated by Claude Code
There was a problem hiding this comment.
@PhysShell, thanks — that addresses my concern. Adding Applier.revert for the non-success and re-audit-failure paths brings the flow back in line with the documented safety contract, and surfacing reverted in the ledger is a nice touch for observability.
🐇✅
| ``` | ||
| select(rule) → dry-run → diff → apply → re-audit → assert NO new findings → tier gate | ||
| ``` |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a fence language.
This is shell syntax, and the bare fence will trigger MD040 in markdownlint.
Suggested fix
-```
+```bash📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ``` | |
| select(rule) → dry-run → diff → apply → re-audit → assert NO new findings → tier gate | |
| ``` |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 7-7: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@fix/README.md` around lines 7 - 9, The README snippet is using a bare fenced
code block, which triggers markdownlint MD040 because the content is shell
syntax. Update the fenced block around the pipeline in README.md to use a Bash
language tag, and keep the existing content under the same block so the shell
command is clearly identified. Use the fenced snippet near the select(rule) →
dry-run → diff → apply → re-audit → assert NO new findings → tier gate text to
locate it.
Source: Linters/SAST tools
There was a problem hiding this comment.
@coderabbitai Done in 56ec0db — the pipeline fence is now tagged text (it's a flow diagram, not shell), clearing MD040.
Generated by Claude Code
| ```bash | ||
| python3 fix/tests/test_orchestrate.py # the contract tests | ||
| python3 -m fixarm.cli --fixture fix/fixtures/idisp001-clean --rule IDISP001 # demo | ||
| ``` |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the demo command runnable from the repo root.
fixarm lives under fix/, so python3 -m fixarm.cli will not resolve from the root checkout unless you add fix/ to PYTHONPATH or cd fix first.
Suggested fix
- python3 fix/tests/test_orchestrate.py # the contract tests
- python3 -m fixarm.cli --fixture fix/fixtures/idisp001-clean --rule IDISP001 # demo
+ PYTHONPATH=fix python3 fix/tests/test_orchestrate.py # the contract tests
+ PYTHONPATH=fix python3 -m fixarm.cli --fixture fix/fixtures/idisp001-clean --rule IDISP001 # demo📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ```bash | |
| python3 fix/tests/test_orchestrate.py # the contract tests | |
| python3 -m fixarm.cli --fixture fix/fixtures/idisp001-clean --rule IDISP001 # demo | |
| ``` |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@fix/README.md` around lines 13 - 16, The README demo command is not runnable
from the repo root because the module path for fixarm is unresolved; update the
documented command in the README snippet to use a root-compatible invocation, or
explicitly include the package path setup needed to find fixarm from the
checkout root. Refer to the demo command example in the README and make sure the
instructions clearly work without requiring the user to manually cd into fix/
first.
There was a problem hiding this comment.
@coderabbitai Done in 56ec0db — both commands are now prefixed with PYTHONPATH=fix so they run from the repo root without a cd fix.
Generated by Claude Code
- rollback on every non-success path: REJECTED/NO_EFFECT and a throwing re-audit now revert the worktree via a new Applier.revert hook (Replay restores before/; real adapters git checkout+clean). FixResult.reverted surfaces it in the ledger. (Codex + CodeRabbit: tree left mutated) - line_tol is now true within-distance matching per (rule, basename) group, not line//(tol+1) bucketing — no more false regressions at bucket edges. (Codex + CodeRabbit) - ReplayApplier.apply models file deletions (before-only files removed), so the replayed tree matches after.findings.json. (CodeRabbit) - cli.py and tests reap their temp workdirs (finally / context manager); removed the wrong 'OS reaps tmp' comment. (CodeRabbit) - README: fence language for MD040 + PYTHONPATH=fix so commands run from root. (CodeRabbit) - tests: +within-tolerance, +reject-reverts-tree; 7/7 on bare python3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LLHz4cevQyXHKZnjzCqhoa
Killer feature #1: where phase-2 diffs *findings* (a violation only shows once it crosses a rule threshold), drift diffs the *structure* between two runs (baseline = main's graph, PR = current) and reports what moved — before it trips a rule. - arch/drift.py: snapshot(g) -> compact, committable {component metrics + namespace dependency surface (incl. external framework edges) + cycle set}. diff(base, cur) -> risk-tagged items: new/resolved cycles (type/ns/asm), new/removed dependencies, Ce coupling jumps, instability shifts. gate(d, level) for a PR ratchet. A new dependency into a sensitive_targets layer (SQL/WPF) is High. - arch/drift_cli.py: --save-snapshot, then --baseline (snapshot OR raw graph.json) + --graph -> drift.json + a PR-friendly drift.md grouped by 🔴/🟠/🔵. --gate-level fails (exit 2) on drift at/above a risk; report-only otherwise. - arch/rules.json: `drift` config block (thresholds + sensitive_targets). - docs: phase-4 section marked engine-ready with a worked example. - tests: +10 (identical=empty, new cycle=high, new SQL dep=high, plain dep=medium, coupling jump, resolved cycle=info, gate high-only, raw-graph baseline, CLI snapshot->gate) -> 41/41, -O safe. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LLHz4cevQyXHKZnjzCqhoa
2 participants
Grounds the fix arm in the real STS run (72569 findings): 85% come from
analyzers shipping code fixes, so we wire roslynator fix / dotnet format
rather than build an engine. Documents the off-the-shelf landscape
(appliers vs OpenRewrite/Copilot-Autofix + why they don't fit), the
risk-tier gate, the safety contract (dry-run -> diff -> re-audit
no-new-findings -> tier gate), the OWN001/OWN014 bespoke fixer, the
MSBuild build-wall + fix-spike, and a CI/Linux-native first slice.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LLHz4cevQyXHKZnjzCqhoa
Summary by CodeRabbit
New Features
Documentation
Tests