Skip to content

Adding Named Modules, VS Code, Fixes - #911

Merged
PatrickJS merged 28 commits into
PatrickJS:masterfrom
katallaxie:master
Aug 29, 2016
Merged

PatrickJS merged 28 commits into
PatrickJS:masterfrom
katallaxie:master

Conversation

@katallaxie

@katallaxie katallaxie commented Aug 27, 2016 •

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Using webpack-dashboard in dev mode
  • Adding NamedModulesPlugin in dev mode
  • Adding VSCode config
  • Fixing TravisCI by using npm >= 3
  • ESLint for config/**/*.js

* Using webpack-dashboard in dev mode
* Adding NamedModulePlugin in dev mode
@katallaxie katallaxie changed the title Add support for webpack-dashboard and NamedModulePlugin Add support for webpack-dashboard and NamedModulesPlugin Aug 27, 2016
@katallaxie katallaxie changed the title Add support for webpack-dashboard and NamedModulesPlugin Adding Webpack Dashboard, Named Modules, VS Code Config Aug 27, 2016
@katallaxie katallaxie changed the title Adding Webpack Dashboard, Named Modules, VS Code Config Adding Webpack Dashboard, Named Modules, ESLint, VS Code Aug 27, 2016
@PatrickJS

Copy link
Copy Markdown
Owner

config should be re-done in typescript using ts-node to be honest

@PatrickJS

Copy link
Copy Markdown
Owner

if you remove the webpack-dashboard, and ESLint then this LGTM

Comment thread config/webpack.dev.js
*
* See: https://github.com/webpack/webpack/commit/a04ffb928365b19feb75087c63f13cadfc08e1eb
*/
new NamedModulesPlugin(),

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@katallaxie katallaxie changed the title Adding Webpack Dashboard, Named Modules, ESLint, VS Code Adding Named Modules, VS Code, Fixes Aug 29, 2016
@PatrickJS
PatrickJS merged commit ee0c85e into PatrickJS:master Aug 29, 2016
@PatrickJS

Copy link
Copy Markdown
Owner

thanks!

@PatrickJS

Copy link
Copy Markdown
Owner

I also added you to the repo and org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants