Repository navigation
update to rc.5 #843
Description
merge changes from https://github.com/AngularClass/angular2-seed
Angular 2 Seed will be the simple version of this repo. Both will be updated to Webpack 2
Metadata
Metadata
Assignees
Labels
No labels
Activity
aminebizid commentedon Aug 9, 2016
Great!
PatrickJS commentedon Aug 9, 2016
I have a simple version of the starter here https://github.com/AngularClass/angular2-seed that's updated to
rc.5it's where I experiment for changes in this reposhahmirn commentedon Aug 10, 2016
I tried to use RC5 and ran into an issue with uri.match is not a function, which is caused by _split being called on moduleId by angular, which in the case of webpack is a number.
angular/angular#10595 is a PR created by @mhamel06 to fix the issue.
PatrickJS commentedon Aug 10, 2016
don't use
moduleIdin webpackshahmirn commentedon Aug 10, 2016
How about dependencies being used in the project that are using moduleId that we have no control over?
PatrickJS commentedon Aug 10, 2016
@shahmirn are they public deps on github? if so can you give me a link to the repo. You would use a loader to rewrite it and remove the
moduleIdbut I need to create it.mhamel06 commentedon Aug 10, 2016
sorry not at computer now but I think my issue may have been from the material repo, since I still had the issue after removing my moduleIDs. this is with the latest Ng module version. https://github.com/angular/material2/blob/master/src/components/sidenav/sidenav.ts
I think ensuring that the _split function is only called with the expected type should fix the core issue.
PatrickJS commentedon Aug 10, 2016
@mhamel06 @shahmirn
ok fixed via
https://github.com/AngularClass/angular2-seed/commit/84aacc18682bbe38631cd3c457d9e90944d6fd0e
houko commentedon Aug 10, 2016
when rc5 will be updated in this project? @gdi2290 thank you
snird commentedon Aug 11, 2016
@gdi2290 the seed repo uses webpack 2, is it planned to update this starter repo to webpak 2 as well?
PatrickJS commentedon Aug 11, 2016
yup this repo will be updated to webpack2 and rc5
DzmitryShylovich commentedon Aug 11, 2016
eta?
paralin commentedon Aug 11, 2016
Looking forward to this, if you'd like me or the 100 other people here waiting for this to help, let us know how!
I noticed when trying to update my own project that the hot loading stuff might be a bit ?? with rc5. Because you have to declare all of the components in a single place. Are we going to make multiple modules for a project, maybe? Seems really a lot more complicated than before.
yyyyyyuanfei commentedon Aug 12, 2016
Agree with @paralin , I also concern that if we're putting all the deps in one place, isn't it break the encapsulation of each component as they might depend on other libs that are not imported.
46 remaining items
mac-bhaird commentedon Aug 23, 2016
Awesome!
In the process of updating myself. Ran into the following,
Can't bind to '<attribute>' since it isn't a known property of '<component>'.The same challenge is referenced in this issue: angular/angular-cli#1644
dherges commentedon Aug 23, 2016
@qq83387856 can you share some code? maybe a diff what you've changed?
mac-bhaird commentedon Aug 23, 2016
hmr was fixed in the recent update just by changing the angular router dependency (the only bit I pulled in so far)
PatrickJS commentedon Aug 25, 2016
alright webpack2, async, hmr are all working now
fxck commentedon Aug 25, 2016
Great. What's next now @gdi2290? I wonder whether I should wait for that DLL stuff before I start refactoring everything..
PatrickJS commentedon Aug 25, 2016
DLLs will take some time since I have to deconstruct the config folder and move all of the comments into the type definition file
shlomiassaf commentedon Aug 26, 2016
@gdi2290 great advanced work!
I wonder if DLL's can be later on used for lazy routes/modules.
In big apps it might be useful.
PatrickJS commentedon Aug 26, 2016
async load DLLs? ya, it's possible
fxck commentedon Aug 26, 2016
I tried merging DLL myself. Failed miserably, there are countless typescript errors just by changing configs from js to ts.
Should the config folder be part of
excludein tsconfig or something?When it's not in exclude, it's complaining about constants being re-declared, even when I'm not
requireing the other files those constants are declared at. When it is in exclude, it cannot findrequireetc..PatrickJS commentedon Aug 26, 2016
ya exclude the config folder
fxck commentedon Aug 26, 2016
What do I do with
Cannot find name 'require'.etc. then though? Use imports instead?yyyyyyuanfei commentedon Aug 29, 2016
Any plan for the migration guide?
fxck commentedon Sep 1, 2016
@gdi2290 any update on those dlls? :)
jshamley commentedon Sep 7, 2016
I had some similar errors and had to remove my typings folder from app root. Hope that helps someone else.