You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for creating the issue. the issue you're looking for is zloirock/core-js#152. Reflect does include getMetadata and I can understand the confusion you may have since it wasn't documented in the repo. I'm going to close this issue but if you like it would help everyone else if we updated the FAQ to mention this. If you could edit the readme to include this then that would be great. thanks!
I am still stuck. In the current polyfill.ts, we import 'core-js';
which builds typings for the "old" Reflect definition.
The Reflect typing in typings/core-js/index.d.ts show Reflect without "getMetaData".
Do I have to add a specific import in polyfill, AND add a typing in typings.json?
I'm trying all sorts of ways to do this, and I cannot seem to get teh right definition of "Reflect" to my code. @zloirock - I see it in your library, but my question is how to integrate it into the starter kit
Looks like need update type definitions for core-js because all use definitions for 0.9.7 version - May 2015. I'm not an expert in TypeScript, so feel free add a PR. Or, I think, in addition, you can use definitions for reflect-metadata package.
Activity
zloirock commentedon Mar 23, 2016
core-js2.1+containsReflect.getMetadataO_oPatrickJS commentedon Mar 24, 2016
Thanks for creating the issue. the issue you're looking for is zloirock/core-js#152. Reflect does include getMetadata and I can understand the confusion you may have since it wasn't documented in the repo. I'm going to close this issue but if you like it would help everyone else if we updated the FAQ to mention this. If you could edit the readme to include this then that would be great. thanks!
zloirock commentedon Mar 24, 2016
If you mean
core-jsrepo, it's already documented here.mbcooper commentedon Mar 24, 2016
I am still stuck. In the current polyfill.ts, we
import 'core-js';which builds typings for the "old" Reflect definition.
The Reflect typing in typings/core-js/index.d.ts show Reflect without "getMetaData".
Do I have to add a specific import in polyfill, AND add a typing in typings.json?
I'm trying all sorts of ways to do this, and I cannot seem to get teh right definition of "Reflect" to my code.
@zloirock - I see it in your library, but my question is how to integrate it into the starter kit
zloirock commentedon Mar 24, 2016
Looks like need update type definitions for
core-jsbecause all use definitions for0.9.7version - May 2015. I'm not an expert in TypeScript, so feel free add a PR. Or, I think, in addition, you can use definitions forreflect-metadatapackage.PatrickJS commentedon Mar 24, 2016
I'll reopen and fix the type definitions
PatrickJS commentedon Mar 30, 2016
thanks for the issue. fixed via 8205315