e2e error: TSError: Unable to compile TypeScript #452

Activity

1. Tjeerd-menno commented on Mar 23, 2016

   

   Tjeerd-menno

   on Mar 23, 2016

   More actions

   I'm getting the same error

   Node 5.6.0
   TypeScript 1.8.9
   Windows 7 (64-bit)

   Could it be related to this Angular 2 issue? angular/angular#7660
2. vdavyskiba commented on Mar 23, 2016

   

   vdavyskiba

   on Mar 23, 2016

   More actions

   Occure same issue:
   source:
   
import {describe, it, beforeEach, expect} from 'angular2/testing';

   describe('App', () => {

   beforeEach(() => {

   browser.get('/');
   

   });
});


   Ouput:

   D:\VITALY\work\angular2\angular2-webpack-starter>npm run e2e

   angular2-typescript-webpack-firebase-nest@0.0.1 pree2e D:\VITALY\work\angular2\angular2-webpack-starter
   npm run webdriver:update -- --standalone

   angular2-typescript-webpack-firebase-nest@0.0.1 webdriver:update D:\VITALY\work\angular2\angular2-webpack-starter
   webdriver-manager update "--standalone"

   selenium standalone is up to date.
   chromedriver is up to date.

   angular2-typescript-webpack-firebase-nest@0.0.1 e2e D:\VITALY\work\angular2\angular2-webpack-starter
   protractor

   Using FirefoxDriver directly...

   [launcher] Running 1 instances of WebDriver

   ? Unable to compile TypeScript

   src\webapp\pages\app\app.e2e.ts (7,5): Cannot find name 'browser'. (2304)
src\webapp\pages\app\app.e2e.ts (13,19): Cannot find name 'browser'. (2304)
src\webapp\pages\app\app.e2e.ts (23,19): Cannot find name 'element'. (2304)
src\webapp\pages\app\app.e2e.ts (23,27): Cannot find name 'by'. (2304)

3. chuson1996 commented on Mar 24, 2016

   

   chuson1996

   on Mar 24, 2016

   More actions

   Same here
4. tobek commented on Mar 27, 2016

   

   tobek

   on Mar 27, 2016

   Contributor

   More actions

   Issue is described here angular/angular#7660 and looks like it will be fixed in a future release of angular. In the mean time you can fix it by adding this to your tsconfig.json:

   "files": [ "src/main.ts", "typings/browser.d.ts", "node_modules/zone.js/dist/zone.js.d.ts" ],
   

   👍React with 👍4Reacted by Brian Lewis, Carlos Ramirez, Mostafa Fateen and Miles Stanfield

   🎉React with 🎉1Reacted by Elias Cooper
5. aegyed91 commented on Mar 27, 2016

   

   aegyed91

   on Mar 27, 2016

   More actions

   @tobek thanks, the compiler needs zone.js.d.ts

   but, its not that easy to fix it, because if you check the current tsconfig.json node_modules are excluded, even if you add ./node_modules/zone.js/dist/zone.js.d.ts to filesGlob it won't gain any precedence over the node_modules exclusion. If you remove the node_modules exclusion you will get a bunch of duplicate identifier errors

   Nevertheless ./src/custom-typings.d.ts is not a wise decision:

   • what if in the future you will have to define several dozen of libs?
   • what if you want to define them good not just to shut the compiler up? that single file will grow very big
   • what if you want to temporary load ./node_modules/zone.js/dist/zone.js.d.ts?

   I think it would be wiser to create ./manual-typings/ and place all the custom .d.ts file there and load this folder. This is where i added the missing zone.js.d.ts file. So, something like this.
6. tobek commented on Mar 27, 2016

   

   tobek

   on Mar 27, 2016

   Contributor

   More actions

   That definitely seems like a more elegant/maintainable long-term solution, however it seems like the fix on angular's end is coming soon so hopefully we won't have to deal with this (and ideally shouldn't have to). My hack solution above worked for me as a temporary fix until the angular team fixes this.
7. StormToft commented on Apr 2, 2016

   

   StormToft

   on Apr 2, 2016

   Author

   More actions

   Closing this because this issue no longer occurs in master at bf46a9c. Thanks all!
8. StormToft

   closed this as completedon Apr 2, 2016