Skip to content

router-active.ts is not necessary anymore  #420

Closed

Description

@MurhafSousli

Angular2 beta 9 has a new feature that adds "router-link-active" class to the activated menu item without configuration.

Feature: angular1_router: Add ng-link-active class to active ng-link (11e8aa2), closes #6882

you may want to deprecate the file.

Activity

  1. PatrickJS commented on Mar 13, 2016

    @PatrickJS
    Owner

    that's for angular1

  2. MurhafSousli commented on Mar 13, 2016

    @MurhafSousli
    Author
  3. sasidhar commented on Mar 14, 2016

    @sasidhar

    @MurhafSousli You are correct.

    router: router-link-active CSS class support (36eb9d3), closes #3209

    We have "router-link-active" available in Angular 2 from 2.0.0-alpha.37 (2015-09-09)

    I tried on my local machine and its working fine without router-active directive.

  4. PatrickJS commented on Mar 14, 2016

    @PatrickJS
    Owner

    router link is fine. when you want the active class on the parent that's a problem

    <li class="active">
      <a href="#"></a>
    </li>
  5. sasidhar commented on Mar 14, 2016

    @sasidhar

    @gdi2290 Ok.

    Then we need router-active.ts

  6. goodmind commented on Jul 28, 2016

    @goodmind

    @gdi2290 why it is removed? how can I set class on parent now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions