Preserve influences on fetched trade items - #10187
Draft
mcagnion wants to merge 1 commit into
Draft
Conversation
Trader reconstructs fetched item text instead of decoding the supplied raw string. Restore historical and eldritch influence markers during that reconstruction so imported search results retain their influence. Addresses the regression introduced by PR 10073.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trader reconstructs fetched item text from the trade API response. That reconstruction omitted influence fields, so results found with an Elder influence filter were displayed and imported as non-influenced items.
Preserve all historical and Eldritch influence markers while rebuilding fetched items. This keeps the parsing correction from #10073 while restoring the influence information that the previous decoded item text carried automatically.
Validation