Skip to content

Fix Chip Away not using a global limit + count Foulgrasp Brand limit stat - #10141

Merged
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
Trifall:fix/chip-away-cdr-cap
Aug 6, 2026
Merged

Fix Chip Away not using a global limit + count Foulgrasp Brand limit stat#10141
LocalIdentity merged 3 commits into
PathOfBuildingCommunity:devfrom
Trifall:fix/chip-away-cdr-cap

Conversation

@Trifall

@Trifall Trifall commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #10137

Description of the problem being solved:

Multiple Chip Away cluster jewel notables were stacking their per-Brand cooldown recovery rate for Brand Recall past the 40% total cap. It now has a global limit matching how Vast Power / Expansive Might works currently.

The active Brand count behind those per-Brand stats was also capped by a player-scoped limit that ignored support gems. Foulgrasp Support grants its supported skill +2 to maximum number of Brands as a skill-scoped modifier, so a build with the 3 base brands plus Foulgrasp could place 5 brands in game (3 Armageddon Brand + 2 Storm Brand active simultaneously) while it was previously capped at 3. The cap now uses the brand skill's own modifier list, which includes support gems, and takes the highest limit across all brand skills.

Also to note on that last part: In-game, casting a lower-limit brand skill after the pool is full deletes the oldest brands.
Example: Storm Brand = Limit 5, Arma Brand = Limit 3. Cast 5 Storm Brand --> Cast 1 Arma Brand --> (2 Storm get deleted down to 3 max, and 1 Storm deleted and replaced with 1 Arma) --> 2 Storm + 1 Arma = final state. This is not accounted for in PoB currently since its more of a rotational thing, and I am pretty sure cast order isn't simulated. The player can still manually enter the active amount still if necessary of course.

Steps taken to verify a working solution:

  • Added Chip Away entries in the Mod Parser that pool the 40% cap across all copies via a globalLimitKey, plus the matching cache entry
  • Updated the cap of the ActiveBrand multiplier by the brand skill's skill-scoped limit, with the highest limit across all brand skills
  • Added regression tests:
    • Two Chip Away notables cap at 40% with 10 brands, a single notable gives 12% with 3 brands
    • Foulgrasp support's +2 max active brands counts toward the active Brand count
    • Takes highest limit across multiple brand skills
  • Full test suite passed

Link to a build that showcases this PR:

PoB for PoE1 build code (from issue)

https://pobb.in/RJqhIh4i77MJ

Before screenshot:

(Over 40% CDR exceeding global limit, 7x active brands)
Screenshot_20260805_195346

After screenshot:

(Capped to 40%, 9x active brands)
image

@LocalIdentity LocalIdentity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it to use the existing parsing line instead of adding new ones

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Aug 6, 2026
@LocalIdentity LocalIdentity changed the title Add Chip Away notable global limit; count brand support limits Fix Chip Away not using a global limit + count Foulgrasp Brand limit stat Aug 6, 2026
@LocalIdentity
LocalIdentity merged commit 6e32cdf into PathOfBuildingCommunity:dev Aug 6, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chip away brand cluster notable stacking wrong

2 participants