Fix Chip Away not using a global limit + count Foulgrasp Brand limit stat - #10141
Merged
LocalIdentity merged 3 commits intoAug 6, 2026
Merged
Conversation
LocalIdentity
approved these changes
Aug 6, 2026
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I fixed it to use the existing parsing line instead of adding new ones
LocalIdentity
merged commit Aug 6, 2026
6e32cdf
into
PathOfBuildingCommunity:dev
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10137
Description of the problem being solved:
Multiple Chip Away cluster jewel notables were stacking their per-Brand cooldown recovery rate for Brand Recall past the 40% total cap. It now has a global limit matching how Vast Power / Expansive Might works currently.
The active Brand count behind those per-Brand stats was also capped by a player-scoped limit that ignored support gems. Foulgrasp Support grants its supported skill
+2 to maximum number of Brandsas a skill-scoped modifier, so a build with the 3 base brands plus Foulgrasp could place 5 brands in game (3 Armageddon Brand + 2 Storm Brand active simultaneously) while it was previously capped at 3. The cap now uses the brand skill's own modifier list, which includes support gems, and takes the highest limit across all brand skills.Also to note on that last part: In-game, casting a lower-limit brand skill after the pool is full deletes the oldest brands.
Example: Storm Brand = Limit 5, Arma Brand = Limit 3. Cast 5 Storm Brand --> Cast 1 Arma Brand --> (2 Storm get deleted down to 3 max, and 1 Storm deleted and replaced with 1 Arma) --> 2 Storm + 1 Arma = final state. This is not accounted for in PoB currently since its more of a rotational thing, and I am pretty sure cast order isn't simulated. The player can still manually enter the active amount still if necessary of course.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
PoB for PoE1 build code (from issue)
Before screenshot:
(Over 40% CDR exceeding global limit, 7x active brands)

After screenshot:
(Capped to 40%, 9x active brands)
