Avoid copying enchants when editing item - #10089
Merged
LocalIdentity merged 1 commit intoAug 3, 2026
Merged
Conversation
LocalIdentity
approved these changes
Aug 3, 2026
LocalIdentity
added
crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10018, fixes #10015
Description of the problem being solved:
The fix was to simply move the copy call to the same place as quality normalisation. That was already there to avoid the same problem happening with quality. I also change the enchant button text to clarify that you can also remove enchants there. I also added a nil check to the delve implicit code
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A