Skip to content

Fix base radius of Cleave + Vaal Cleave - #10045

Merged
LocalIdentity merged 1 commit into
devfrom
fix_cleave-area
Jul 28, 2026
Merged

Fix base radius of Cleave + Vaal Cleave#10045
LocalIdentity merged 1 commit into
devfrom
fix_cleave-area

Conversation

@LocalIdentity

Copy link
Copy Markdown
Contributor

Fixes #10027

Description of the problem being solved:

The skills had 2 stats mapped to the radiusExtra skill mod so it would randomly choose 1 of them on launch.
Now uses a base mod for the nearby enemy mod so that it always works properly

Link to a build that showcases this PR:

https://maxroll.gg/poe/pob/2pr30f0t

Before screenshot:

image

After screenshot:

image

The skills had 2 stats mapped to the radiusExtra skill mod so it would randomly choose 1 of them on launch.
Now uses a base mod for the nearby enemy mod so that it always works properly
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Jul 28, 2026
@LocalIdentity
LocalIdentity merged commit 0d7f199 into dev Jul 28, 2026
3 checks passed
@LocalIdentity
LocalIdentity deleted the fix_cleave-area branch July 28, 2026 20:50
@TheCityVault

Copy link
Copy Markdown
Contributor

Verified against dev head (PR #10045): the same repro build now prints
AreaOfEffectRadius 32 on 8/8 fresh processes — the flap is gone and the value
matches the expected sum (20 base + 11 level-scaled + 1 per-nearby). Moving the
per-nearby component to an AreaOfEffect BASE mod fixes both halves at once.

We also re-scanned all 1,513 skill blocks at dev head for the same pattern (two
stats writing one skillData key). Both reachable sites are gone; the only
structural match left is StalkingPustule, and we believe it's unreachable — its
own-map stat never seems to materialize at runtime for the item-granted skill, so
there's no coin to flip. Flagging it in case that reasoning is wrong, since you'd
know better than we would. The 24 new skill blocks on dev head don't add any new
sites.

Thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences

Projects

None yet

2 participants