Skip to content

Add support for 3.29 vestigial and intangibility parsing - #10026

Merged
Wires77 merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:329-copypaste
Aug 1, 2026
Merged

Add support for 3.29 vestigial and intangibility parsing #10026
Wires77 merged 2 commits into
PathOfBuildingCommunity:devfrom
vaisest:329-copypaste

Conversation

@vaisest

@vaisest vaisest commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Fix #10049

Description of the problem being solved:

This PR fixes vestigial items not importing at all because they have a prefix in the base name similar to synthesised items. It also adds support for the vestigial and intangibility parsing to show them properly.

Steps taken to verify a working solution:

  • None yet

Link to a build that showcases this PR:

Item Class: Staves
Rarity: Rare
Hate Bane
Battery Staff
--------
Staff
Physical Damage: 65-120
Critical Strike Chance: 7.50%
Attacks per Second: 1.25
Weapon Range: 1.3 metres
Intangibility: 8%
--------
Requirements:
Level: 70
Str: 117
Int: 117
--------
Sockets: W-W-W-W-W 
--------
Item Level: 86
--------
{ Implicit Modifier }
Spend Energy Shield before Mana for Costs of Socketed Skills
+161(140-165) to maximum Energy Shield
--------
{ Prefix Modifier "Shocking" (Tier: 3) — Damage, Elemental, Lightning, Caster }
Adds 18(8-19) to 250(248-261) Lightning Damage to Spells
{ Prefix Modifier "Magmancer's" (Tier: 1) — Elemental, Fire, Caster, Gem }
+4 to Level of all Fire Spell Skill Gems
{ Prefix Modifier "Professor's" (Tier: 5) — Damage, Caster }
80(70-95)% increased Spell Damage
{ Suffix Modifier "of Prestidigitation" (Tier: 3) — Caster, Speed }
37(32-37)% increased Cast Speed
{ Suffix Modifier "of Ruin" (Tier: 2) — Caster, Critical }
128(120-134)% increased Spell Critical Strike Chance
{ Suffix Modifier "of Ferocity" (Tier: 2) — Damage, Critical }
+32(30-34)% to Global Critical Strike Multiplier
--------
Note: ~b/o 2 divine
Item Class: Shields
Rarity: Unique
Trolltimber Spire
Vestigial Cedar Tower Shield
--------
Chance to Block: 25%
Armour: 259 (augmented)
--------
Requirements:
Level: 39
Str: 47
--------
Sockets: W-W W 
--------
Item Level: 86
--------
{ Vestigial Implicit Modifier }
30% increased Warcry Cooldown Recovery Rate
--------
{ Unique Modifier — Defences, Armour }
144(130-150)% increased Armour
{ Unique Modifier — Life }
+54(40-60) to maximum Life
{ Unique Modifier }
15% increased Area of Effect for Skills used by Totems
{ Unique Modifier — Life }
0.5% of Damage dealt by your Totems is Leeched to you as Life
(Leeched Life is recovered over time. Multiple Leeches can occur simultaneously, up to a maximum rate)
{ Unique Modifier — Life }
You and your Totems Regenerate 0.5% of Life per second for each Summoned Totem
--------
The problem with working fresh trolltimber:
by the time you've carved out one end, 
the other has sprouted fresh roots!
--------
Note: ~b/o 3 chaos

Before screenshot:

image

After screenshot:

image image

@vaisest vaisest added the bug: behaviour Behavioral differences label Jul 27, 2026
@vaisest vaisest changed the title Add crafted item modifiers as unscaled lines Add support for 3.29 vestigial and intangibility parsing Jul 27, 2026
@Wires77
Wires77 merged commit 9919de4 into PathOfBuildingCommunity:dev Aug 1, 2026
3 checks passed
@emptytriangle

Copy link
Copy Markdown

how long is this going to take to get released? We're 2 weeks into the league here people. This critical change that stops all import of all characters has been finished and ready for testing for a week, get the lead out people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: behaviour Behavioral differences

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cant import item with "All Sockets Linked" (Vestigial Implicit Modifier)

3 participants