Refactor custom modifiers block into toggleable blocks - #10020
Merged
LocalIdentity merged 8 commits intoAug 3, 2026
Conversation
Contributor
|
Pretty neat. Does the toggle have support for the comparison tooltip? I've wanted something like that for the custom mods for a long time |
Contributor
Author
It doesn't but I'll try to implement it |
Contributor
Author
|
Done: |
Clear legacy customMods input after migrating it into customModsList so disabled migrated blocks do not still apply through the headless fallback. Route mod browser double-click through ListControl's existing OnSelClick doubleClick argument.
LocalIdentity
approved these changes
Aug 3, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I fixed a small issue with the box and also deduped some code by making it use existing structures
thanks for making the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Some builds require various custom modifiers (eg: minion builds), and I was getting annoyed by the UX of enabling/disabling individual mods one by one.
So I went a head and refactored the Custom Modifier block so it supports child blocks with a proper title and a checkbox to toggle them on/off.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
EDIT:
I also added a mod browser:
And stats comparison tooltip: