Add support for Pacts - #10009
Merged
LocalIdentity merged 5 commits intoAug 5, 2026
Merged
Conversation
Peechey
marked this pull request as ready for review
August 4, 2026 11:10
added 3 commits
August 5, 2026 18:36
Refactor Pact calculations to use the modifiers exported by each Pact skill and share one uptime calculation. Add uptime-scaled Beidat coverage bonuses and K’Tash utility effects, support instant damaging Vaal skills, and prevent Lycia from affecting totem skills. Move damage restrictions into the skill stat mappings and add focused tests for Pact effects and eligibility.
LocalIdentity
approved these changes
Aug 5, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I vastly simplified the calc and fixed the exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds basic support for Pacts of Beidat, Ghorr, K'Tash, and Lycia. Somewhat similar to exerted attacks, the empowered stats are scaled by uptime of the Pact against the cast time of the affected spells. I've copied the CalcSections from Exerted as well, but we probably want to adjust a few or most of those columns. Uptime and number of empowered seem most important, however.
This PR is not adding support for the Triggered sections of Pact of Ghorr nor Pact of Lycia. Godspeed to the trigger logic maniacs.
I also do not have Pact of K'Tash's Soul Gain Prevention Duration working as we calc duration sooner than we run the uptime logic. Thinking that one over a little.
This PR is not adding support for the Affliction downsides.
Added tests for UpTimeRatio validation.
Link to a build that showcases this PR:
After screenshot: