Repository navigation
Fix crash when importing items with +1 suffix rune - #2175
Merged
Merged
Conversation
vaisest
marked this pull request as draft
June 12, 2026 17:30
vaisest
marked this pull request as ready for review
June 12, 2026 17:32
LocalIdentity
approved these changes
Jun 23, 2026
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
Will need to fix the import for items that have removed the +1 suffix mod from the item bit still retained the mod
2 tasks done
This was referenced Jun 28, 2026
Closed
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Jul 21, 2026
* Apply changes from PathOfBuildingCommunity/PathOfBuilding-PoE2#2175 * Fix merge issue --------- Co-authored-by: vaisest <vaisest@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes crash on 7 mod rares. Simply adds 3 more controls. This doesn't change how they're created and they are still made when itemsTab is initialised. I.e., this doesn't add support for an unlimited amount
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: