Repository navigation
Add support for many Unique mods - #1826
Merged
LocalIdentity merged 7 commits intoMay 18, 2026
Merged
Conversation
add deprecated list for ModParser to ignore certain skillNames
LocalIdentity
approved these changes
May 18, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I fixed the handling of temporalis so it didn't add negative cooldown timers to all skills and it also now correctly caps a skil at 0.1 cooldown
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
* add support for many uniques * better pattern match * update Candlemaker parsing add deprecated list for ModParser to ignore certain skillNames * map instead of list * only blacklist Flammability * Fix temporalis handling --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding parsing for a variety of mods from these Uniques:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
Asphyxia's Wrath
The Bringer of Rain
same behavior as pob1
Candlemaker
Feathered Fortress
before
after
Idol of Uldurn
Myris Uxor
Prism Guardian
Skin of the Loyal
Temporalis
The Whispering Ice