Repository navigation
Fix Rathpith Globe damage not working with Crown of Eyes - #1034
Merged
Merged
Conversation
The way the mod is worded, it reads as if it should be granting generic damage to non-channelled spells, not spell damage to non-channelling skills. GGG appears to have made an exception for the mods on Rathpith where is grants spell damage and spell crit chance
bct8925
pushed a commit
to bct8925/PathOfBuilding-PoE2
that referenced
this pull request
Jun 19, 2026
…ingCommunity#1034) * Fix Rathpith Globe damage not working with Crown of Eyes The way the mod is worded, it reads as if it should be granting generic damage to non-channelled spells, not spell damage to non-channelling skills. GGG appears to have made an exception for the mods on Rathpith where is grants spell damage and spell crit chance * Fix Crown of eyes using the wrong mod --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
LocalIdentity
pushed a commit
to vaisest/PathOfBuilding-PoE2
that referenced
this pull request
Jul 12, 2026
In PR PathOfBuildingCommunity#1034 I changed the handling of the Rathpith mods so that they used ModFlag.Spell instead of Keyword flag That broke the handling of the ailments line though as it uses dotCfg and we specifically strip out the ModFlag.Spell from it so it doesn't get scaled by spell damage. This also stopped the Ailment mod from working though I made it use it's own full parsed line to be simpler and still use KeywordFlag so that the interaction works and the breakdown does too Also added a case so we don't accidentally break this down the line
LocalIdentity
pushed a commit
that referenced
this pull request
Jul 12, 2026
…properly (#2364) * Fix rathpith per 100 life shock mod * Fix Bleed mod not getting scales In PR #1034 I changed the handling of the Rathpith mods so that they used ModFlag.Spell instead of Keyword flag That broke the handling of the ailments line though as it uses dotCfg and we specifically strip out the ModFlag.Spell from it so it doesn't get scaled by spell damage. This also stopped the Ailment mod from working though I made it use it's own full parsed line to be simpler and still use KeywordFlag so that the interaction works and the breakdown does too Also added a case so we don't accidentally break this down the line --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the mod is worded, it reads as if it should be granting generic damage to non-channelled spells, not spell damage to non-channelling skills. GGG appears to have made an exception for the mods on Rathpith where is grants spell damage and spell crit chance
Fixes #1030