馃 [Fix]: Forced reinstalls and CI checks are repaired - #70
Open
Marius Storhaug (MariusStorhaug) wants to merge 8 commits into
Open
馃 [Fix]: Forced reinstalls and CI checks are repaired#70Marius Storhaug (MariusStorhaug) wants to merge 8 commits into
Marius Storhaug (MariusStorhaug) wants to merge 8 commits into
Conversation
Copilot started reviewing on behalf of
Marius Storhaug (MariusStorhaug)
August 28, 2026 23:10
View session
There was a problem hiding this comment.
Pull request overview
This PR updates the Install-Font behavior so -Force can re-install fonts by overwriting existing destination files, and adds regression coverage to ensure forced installs restore the correct file contents.
Changes:
- Enable overwrite behavior during installation by using
FileInfo.CopyTo(dest, overwrite)withoverwritetied to-Force. - Fix the retry-loop guard to check
$fileCopied(copy success) instead of an unrelated/undefined variable. - Add a Pester regression test that corrupts an installed font file and verifies
Install-Font -Forcerestores the original hash.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/functions/public/Install-Font.ps1 |
Implements overwrite-on-force via CopyTo(..., $Force.IsPresent) and corrects retry failure guard logic. |
tests/Fonts.Tests.ps1 |
Adds a regression test validating forced reinstalls overwrite an existing (corrupted) font file. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marius Storhaug (MariusStorhaug)
marked this pull request as ready for review
August 28, 2026 23:57
Marius Storhaug (MariusStorhaug)
requested a review
from a team
as a code owner
August 28, 2026 23:57
Copilot started reviewing on behalf of
Marius Storhaug (MariusStorhaug)
August 29, 2026 07:58
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forced font installation now replaces existing files, the Process-PSModule v8 documentation site uses Zensical, and the existing coverage gate is satisfied with meaningful behavioral tests.
Fixed: Forced font reinstalls
Install-Font -Forceuses the overwrite-capableFileInfo.CopyTooverload.-Forcecontinue to preserve installed files.$fileCopiedinstead of the unrelated$fileRemovedvariable.Fixed: Documentation site build
.github/mkdocs.ymlwith the Process-PSModule v8-compatible.github/zensical.toml.Fixed: Coverage gate and edge cases
Get-Fontfrom returning unrelated state when a configured scope folder is absent.Uninstall-Font.Relevant issues