Repository navigation
🖌️ Add professional filing style, portable configurations, and draggable letterhead layout - #38
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Add a Professional filing presentation preset alongside the unchanged Classic default. Inspired by the layout of this SEC-filed OCC comment letter, rather than presented as an SEC-mandated format, it selects one-inch side margins, 12 pt Times body text with 1.5× line spacing, justified paragraphs with first-line indents, compact headings, 10.5 pt footnotes, plain inset quotations, and page numbers inside the bottom margin. The renderer can shrink the reserved area for short footnote sets and reclaim body space where no page footnotes appear. It also keeps footnote references with the correct fragment of a paragraph split across pages and establishes destinations for rendered notes. The preset is available in the Typography step, through
--render-style professionalon the CLI (withPage X of Nnumbering), and viaTypographySettings.for_style("professional", ...); individual controls remain editable.Add Export config and Import config actions to carry settings between sessions or machines as a versioned
pdf-compiler-config.json. This includes the chosen style, custom typography, letterhead positioning, metadata, footnote and section settings, headers/footers, colors, and licensing options. Import validates the configuration before changing controls, reapplies the selected preset before saved overrides, and preserves the current Markdown and uploaded assets; the exported JSON does not include those files.Add an opt-in draggable first-page letterhead editor. Reposition the existing header, logo/wordmark, visible title, Quote #, date, submission subtitle, and addressee; adjust width, alignment, and visibility; nudge with arrow keys; or add up to 12 custom labeled text fields. Layout data is validated in the browser and renderer, the document body starts below the lowest visible field, and turning the editor off retains the original fixed arrangement.
New regression tests cover preset rendering and explicit overrides, footnote continuation and internal links, first-page placement and invalid layouts, and configuration round-trips, overrides, and rejection of invalid imports. The diff adds these tests; it does not establish that every test was executed in this drafting session.
Related work
The filing preset extends the existing configurable Times typography:
#9
The movable letterhead builds on the distinct visible first-page title and established identity layout:
#11
The footnote handling touches behavior established by clickable note links and configurable endnote placement:
#20
#35
A separately open proposal also implements a draggable letterhead editor. Its overlap is substantive; this branch is not based on that PR, so the two implementations should be reconciled rather than assumed additive:
#37