fix: a permission preset needs the permission it grants - #940
Merged
blaipr merged 1 commit intoSep 24, 2026
Merged
Conversation
blaipr
deleted the
fix/a-permission-preset-needs-the-permission-it-grants
branch
September 24, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every item-preset action is gated on
isMgmItemsPreset()alone ("Default Values Management" on a profile). Choosing who an account is shared with is gated onAccountAcl::getShowPermission(): an application administrator, an account administrator, orisAccPermission().A permission preset is applied by
AccountPreset::addPresetPermissions()to every account its target creates, and that runs outside the$userCanChangePermissionsgate. That gate is what drops hand-picked sharing on the same request. So a user holding only "Default Values Management" could write a preset targeting a colleague, group or profile that shares every account they create from then on with themselves, including for editing. They could never have granted that sharing by hand.Change
ItemsPresetForm::makePermissionPreset()now refuses unless the signed-in user passesgetShowPermission(). The error is "You don't have permission to assign account permissions".isMgmItemsPreset():Tests
mgmItemsPresetis refused. Mutation-verified: it fails without the fix.accPermissiononly about half the time.