analytics: auction with Optable sources is not missed - #356
Open
MO-Thibault wants to merge 2 commits into
Open
MO-Thibault wants to merge 2 commits into
MO-Thibault wants to merge 2 commits into
Conversation
A replayed auction that already carries Optable EIDs read the cache before the hook attached, so it was not truly missed. missed and optableLoaded now reflect that. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A replayed auction with Optable sources read the cache, so it is not missed, but the SDK still was not hooked in when the auction started. optableLoaded goes back to reflecting hook timing only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mosherBT
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An auction is flagged
missedwhen it started before the analytics hook attached to Prebid. That flag ignored whether Optable EIDs were already on the bid requests. When the wrapper reads the EID cache before the hook attaches, the auction is enriched but was still reported as missed.toWitnessnow sendsmissed: missed && optableSources.length === 0.optableLoadedis unchanged and still reflects hook timing only.missedoptableLoadedDownstream
Historical rows can be corrected in SQL with
missed AND ARRAY_LENGTH(optableSources) = 0. HistoricaloptableLoadedvalues are already correct.Test plan
pnpm exec jest lib/addons/prebid/analytics.test.ts: 85/85 passtoWitnessfor a replayed auction with and without Optable sourcesmissed: false, optableLoaded: false🤖 Generated with Claude Code