uid2: hold targeting calls while a token refresh is in flight - #343
Open
etiennelatendresse-optable wants to merge 3 commits into
Open
etiennelatendresse-optable wants to merge 3 commits into
etiennelatendresse-optable wants to merge 3 commits into
Conversation
etiennelatendresse-optable
force-pushed
the
migrate-eid-cache-merge
branch
from
September 15, 2026 16:06
3820f7c to
8dde6d0
Compare
etiennelatendresse-optable
force-pushed
the
uid2-refresh-targeting-lock
branch
from
September 15, 2026 16:06
7a85e06 to
4e735e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A uid2 refresh and a targeting call happening at the same time run the risk of a race condition where a targeting call could happen mid refresh causing a fresh EID, possibly by another matcher, to pair with a stale refresh outcome.
What Changed
uid2-refresh-lockrefreshes register on a counter (trackUid2Refresh) anduid2RefreshIdleresolves when none are in flight.Targeting()awaitsuid2RefreshIdle(2000)before firing. This is a upperbound since the refresh fetch has no timeout. A refresh finishing before the timeout will cause the targeting to happen right away.How to Test
Notes
Co-authored-by: Etienne Latendresse etienne.latendresse@optable.co