id5: add resolveId5 with QA flags, bounded live resolution and a dedicated cache - #341
Open
etiennelatendresse-optable wants to merge 6 commits into
Open
etiennelatendresse-optable wants to merge 6 commits into
etiennelatendresse-optable wants to merge 6 commits into
Conversation
…n QA and init paths
…te by normalized partner id
mosherBT
reviewed
Oct 1, 2026
| } | ||
|
|
||
| const storageAllowed = options.deviceAccess?.() ?? true; | ||
| const cached = storageAllowed ? getCachedId5UserId(partnerId) : null; |
Contributor
There was a problem hiding this comment.
This should be protected by consent signals I think
mosherBT
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Theres need for a
resolveId5/getCachedId5UserId, the on-demand ID5 resolution used to enrich targeting calls.What Changed
resolveId5(partnerId, { isBot?, timeoutMs? }), QA flags first (optableResolveID5ID,optableResolveId5), then a 7-day cache, then a live resolution with ID5's A/B holdout disabled, validating the partner id and rejecting the"0"placeholder.OPTABLE_ID5key instead of_id5metadata piggybacked on a cached EID, same reasoning as the_refrefs-sidecar change in eidCache: add merging targeting responses to core #330: cached EIDs stay wire-clean.onUpdateforever, and a hang blocked targeting.isBotcallbackHow to Test
Notes
Co-authored-by: Etienne Latendresse etienne.latendresse@optable.co