Skip to content

Main thread pick up work - #747

Closed
wvpm wants to merge 1 commit into
paralellise_update_gamestatefrom
main_thread_pick_up_work
Closed

wvpm wants to merge 1 commit into
paralellise_update_gamestatefrom
main_thread_pick_up_work

Conversation

@wvpm

@wvpm wvpm commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on top of #741
The ThreadPool spins up several worker threads and waits for them to finish.
Instead of waiting, it can join them and also work.
This reduces the thread count by 1 and saves some waiting.

@wvpm
wvpm requested a review from a team as a code owner May 20, 2026 19:41
@wvpm wvpm added enhancement Issue that describes an improvement to the project topic:core Issue that applies to core functions, fundamental to the rest of the module labels May 20, 2026
@wvpm
wvpm changed the base branch from master to paralellise_update_gamestate May 20, 2026 19:42
@wvpm
wvpm marked this pull request as draft May 20, 2026 19:42
@wvpm
wvpm force-pushed the main_thread_pick_up_work branch from e3de318 to 2121a03 Compare May 20, 2026 20:22
@wvpm wvpm added performance Issue directly concerned with performance or that is specifically intended to improve performance and removed enhancement Issue that describes an improvement to the project labels May 20, 2026
@wvpm

wvpm commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

performance gains were not enough to justify using the main thread.

@wvpm wvpm closed this May 20, 2026
@wvpm
wvpm deleted the main_thread_pick_up_work branch May 20, 2026 21:08
@Spartan322 Spartan322 added the enhancement Issue that describes an improvement to the project label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issue that describes an improvement to the project performance Issue directly concerned with performance or that is specifically intended to improve performance topic:core Issue that applies to core functions, fundamental to the rest of the module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants