Skip to content

Apply clang-tidy fixes - #384

Merged
Spartan322 merged 1 commit into
masterfrom
apply/clang-tidy
Jul 9, 2025
Merged

Spartan322 merged 1 commit into
masterfrom
apply/clang-tidy

Conversation

@Spartan322

@Spartan322 Spartan322 commented Mar 12, 2025 •

Copy link
Copy Markdown
Member

@Spartan322 Spartan322 added bug Issue that describes something dysfunctional or erroneous enhancement Issue that describes an improvement to the project labels Mar 12, 2025
@Spartan322
Spartan322 marked this pull request as draft March 12, 2025 20:25
@Spartan322
Spartan322 force-pushed the apply/clang-tidy branch 2 times, most recently from 662a0ca to edf1990 Compare March 12, 2025 20:45
Comment thread src/openvic-simulation/defines/AIDefines.cpp Outdated
Comment thread src/openvic-simulation/economy/production/ResourceGatheringOperation.cpp Outdated
Comment thread src/openvic-simulation/interface/GFXObject.cpp
Comment thread src/openvic-simulation/interface/GFXObject.cpp
Comment thread src/openvic-simulation/interface/GFXSprite.cpp Outdated
Comment thread src/openvic-simulation/modifier/ModifierEffectCache.cpp Outdated
Comment thread src/openvic-simulation/modifier/ModifierEffectCache.cpp Outdated
Comment thread src/openvic-simulation/scripts/ConditionalWeight.hpp Outdated
Comment thread src/openvic-simulation/scripts/Script.hpp Outdated
Comment thread src/openvic-simulation/types/fixed_point/FixedPointLUT_2_16_EXP_e.hpp Outdated
@Spartan322
Spartan322 force-pushed the apply/clang-tidy branch 2 times, most recently from 39e2fcf to b2fee04 Compare March 12, 2025 23:24
Base automatically changed from add/pre-commit to master March 13, 2025 12:39
@Spartan322
Spartan322 marked this pull request as ready for review March 13, 2025 12:40
@Spartan322
Spartan322 force-pushed the apply/clang-tidy branch 2 times, most recently from 68eabd1 to 56c1951 Compare March 13, 2025 15:20
@Spartan322 Spartan322 added the salvageable PR that needs to be fixed up for merge and which the author is leaving the PR dormant label Jun 14, 2025
@Spartan322
Spartan322 force-pushed the apply/clang-tidy branch 2 times, most recently from a29158a to 305385e Compare June 16, 2025 08:02
@Spartan322 Spartan322 added topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change and removed salvageable PR that needs to be fixed up for merge and which the author is leaving the PR dormant labels Jun 16, 2025
@wvpm

wvpm commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Move fixed point LUT generator scripts to misc/scripts

This description doesn't match the PR title also I don't see the LUT generator scripts in the PR changes.

Comment thread src/openvic-simulation/modifier/StaticModifierCache.cpp Outdated
Comment thread src/openvic-simulation/modifier/StaticModifierCache.cpp Outdated
Comment thread src/openvic-simulation/scripts/ConditionalWeight.cpp Outdated
wvpm
wvpm previously approved these changes Jul 9, 2025

@wvpm wvpm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking a positve change.
I left some minor comments.

@Spartan322
Spartan322 merged commit 70b22a6 into master Jul 9, 2025
@Spartan322
Spartan322 deleted the apply/clang-tidy branch July 9, 2025 11:47
@wvpm wvpm mentioned this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue that describes something dysfunctional or erroneous enhancement Issue that describes an improvement to the project topic:codestyle Issue that applies stylistic changes to the module, semantics and mechanics should not change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants