Repository navigation
Refactor SCSS - #158
Merged
Merged
Refactor SCSS#158
Conversation
This was referenced Jan 27, 2024
Closed
This comment was marked as outdated.
This comment was marked as outdated.
gonX
added
enhancement
This will help keeping the styleheets updated, and allows us some flexibility in customizing SCSS further
This should help content to render faster for the user
Darkly is still a predominantly dark-theme skin, but has small variations between dark and light mode. A lot of color and pixel-specific settings have been removed as the stock theme is actually surprisingly close what we want. Additionally, having these was hindering correct light/dark mode display. Removing these also allows us to be more flexible with which Bootswatch themes we can use. Many definitions have been moved around to better fit the nesting of SCSS, reducing clutter and increasing readability. Supersedes OpenTabletDriver#154 Fixes OpenTabletDriver#33 Fixes OpenTabletDriver#151
Otherwise we lose some of the styling we had previously
Member
Author
|
Fixed table backgrounds, gonna look into the other stuff now and then merge once the styling looks (mostly) similar |
gonX
marked this pull request as draft
March 11, 2024 07:54
Member
Author
|
New images! New on left / old on right: Linux FAQ
Tablets pageLooks basically identical, so no image attached PluginsMinor color difference in saturated colors
Windows Install Guide
Linux FAQ mobile view
I personally think the sizing changes are fine and can be worked with down the line if we end up not liking them. For now, the award is that we have less custom (S)CSS to manage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darkly is still a predominantly dark-theme skin, but has small variations between dark and light mode.
A lot of color and pixel-specific settings have been removed as the stock theme is actually surprisingly close what we want.
Additionally, having these was hindering correct light/dark mode display.
Removing these also allows us to be more flexible with which Bootswatch themes we can use.
Many definitions have been moved around to better fit the nesting of SCSS, reducing clutter and
increasing readability.
Supersedes #157
Supersedes #154
Fixes #33
Fixes #151