add validation for subscription routes - #4
Merged
Conversation
nxglabs
self-requested a review
October 22, 2023 17:54
nxglabs
approved these changes
Oct 22, 2023
deshabhishek007
added a commit
to deshabhishek007/OpenSign-lfd
that referenced
this pull request
Aug 5, 2026
… links Layout rhythm (OpenSignLabs#4): Contactbook was a single full-width table like every other page. Rebuilt it as a two-pane master/detail — a compact contact list (avatar initials + name + email, selected-row highlight) on the left, a real detail pane on the right (large avatar, name, job/company subtitle, icon-labelled Email/Phone/Company/Job-title fields, and inline Edit + Delete). Edit now happens inline in the pane (EditContactForm) instead of a modal; delete confirms via a single selection-driven dialog. Fully responsive: desktop shows both panes, mobile shows the list and swaps to the detail (with a Back button) on select. All existing behaviour kept — search, A–Z sort, pagination, bulk import, add-contact, load-more. Dead row-action code (handleActionBtn, isOption) removed. Legacy first-login tour retired: the 8-step reactour walkthrough no longer auto-fires on login now that the dashboard "Get started" checklist is the onboarding — HomeLayout.checkTourStatus just records status and leaves the tour closed (component still wired for any future on-demand use; one-line revert to re-enable). Removed the two remaining opensignlabs.com click-through links: the "read more" docs link in the Templates tour (ReportTour.jsx + the <1>/<3> Trans placeholders across all 7 locales) and the Terms link on the org-admin setup page (AddAdmin.jsx) — kept "terms" as plain text since there's no LDF Sign ToS page yet, and dropped the now-unused openInNewTab import. Two new strings (contact-detail-empty-title/desc) translated into all 6 non-English locales. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.