v2.25.0 - #1802
Merged
Merged
Conversation
fix: handle password protected pdf
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds dark mode support and enhances the dashboard with a debounced search, plus UI tweaks and translation updates.
- Introduced a new
ThemeTogglecomponent and integrated it into the header for dark mode support. - Implemented debounced search in
DashboardReportand wired it through to the report table. - Applied consistent
text-base-contentstyling across components and updated translations and dependencies.
Reviewed Changes
Copilot reviewed 80 out of 81 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/pdf/CellsSettingModal.jsx | New modal to configure cell widget options. |
| src/components/dashboard/DashboardReport.jsx | Added search input with debounce, search state, and prop updates. |
| src/components/ThemeToggle.jsx | New component managing dark/light theme toggle. |
| src/components/Header.jsx | Integrated ThemeToggle and logo switching on theme changes. |
| src/components/dashboard/DashboardButton.jsx | Updated base-content styling classes for consistency. |
| public/locales/*/translation.json | Added keys for dark mode, cell-count, and consolidated errors. |
| package.json | Added quill-html-edit-button dependency. |
| src/App.jsx | Fixed typo in a route comment. |
Files not reviewed (1)
- apps/OpenSign/package-lock.json: Language not supported
Comments suppressed due to low confidence (3)
apps/OpenSign/src/components/dashboard/DashboardReport.jsx:50
- [nitpick] The new debounced search handler should be covered by unit or integration tests to ensure it behaves correctly under rapid input changes and network errors.
const handleSearchChange = async (e) => {
apps/OpenSign/src/components/dashboard/DashboardReport.jsx:1
- You use
axios.postin this file butaxiosis not imported; please addimport axios from 'axios';at the top.
import React, { useEffect, useState, useRef } from "react";
apps/OpenSign/src/components/dashboard/DashboardButton.jsx:42
- The inner text container no longer includes
text-base-content, which may lead to inconsistent text color in dark mode; consider re-adding it to maintain styling consistency.
<div className="text-lg ml-3">
prafull-opensignlabs
changed the title
prafull-opensignlabs
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.