Publish a pull request under pr/, not beside the branches (#307) - #330
Merged
adrpo merged 1 commit intoAug 25, 2026
Merged
Conversation
…ca#307) A pull request run was named pr-<N>, so its results landed in branches/pr-<N> next to master, v1.27, cpp and the rest, and its reports in branches/history/pr-<N>. There are 65 directories there today and one per pull request tested would bury them. The name is pr/<N> now, which is a directory of its own: the results of a pull request go to branches/pr/<N>, its reports to branches/history/pr/<N>, and the branches directory holds branches. It is the one job name that keeps the directory part of itself - the others are git branches and only the last part is used, maintenance/v1.27 being tested, stored and published as v1.27 - so that rule is now shared.resultTable() rather than a split("/")[-1] in each of the five scripts that did it. report.py --branches='master pr/<N>' works as a side effect, which it did not before: the name would have been cut down to the number. drop-pr-tables.py takes both spellings, so the tables of the runs made before this can be dropped by the same rule. --- Generated by Claude Code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request run was named
pr-<N>, so its results landed inbranches/pr-16370next tomaster,v1.27,cppand the 65 otherdirectories there, and its reports in
branches/history/pr-16370. One directoryper pull request tested would bury the branches.
The name is
pr/<N>, which is a directory of its own:The one name that keeps its directory
Every other job is named after a git branch and takes only the last part of the
name -
maintenance/v1.27is tested, stored and published asv1.27. That rulewas a
split("/")[-1]in each ofreport.py,all-reports.py,all-plots.py,single-model.pyandpr-report.py; it is now one place:report.py --branches='master pr/<N>'works as a side effect, which it would nothave before: the name would have been cut down to the number.
drop-pr-tables.pymatchespr[-/]<N>, so the tables of the runs made beforethis are dropped by the same rule.
The run that is already there
PR #16370 was tested before this -
pr-16370, 19661 models - and stays exactlywhere it is. Nothing here moves it and nothing needs to: this is for the runs
from here on.
drop-pr-tables.pymatchespr[-/]<N>, so it goes the same way asany other once the pull request is merged or closed.
Tested
Against a sqlite database whose pull request table is
pr/1234:./pr-report.py 1234history/pr/1234/, and the model links point atbranches/pr/1234/...while the baseline ones point atbranches/master/..../report.py --branches='master pr/1234'pr/1234/..../drop-pr-tables.pypr/1234andpr-16357together, drops the merged onetest.py --branch=stable configs/sanityCheck.json, thenreport.py, then thegrepfrom.github/workflows/test.yml: passesGenerated by Claude Code.