Mark models a library no longer has as removed - #329
Merged
Conversation
A library that still loads but has no model with an experiment annotation writes no rows into its branch table, so the newest date there stays at the last run that did have models and the reports go on listing them. Physiomodel lost its annotations in 2021 and master has reported its 12 models ever since; OpenHydraulics, IdealizedContact, Dynawo_1.6.1 and ModelicaTestOverdetermined_3.2.2 are in the same state, and Pharmacolibrary, ExtendedPetriNets, ExternalMemoryLib and Spot never had a model at all. A run now writes a finalphase -1 row for every model the previous run of that library had and it no longer finds. The previous run is the newest one with rows for the library rather than the previous run of the branch, which makes it self-limiting: once written, the removals are themselves that library's newest rows, so a library that stays empty is marked once instead of at every run. Nothing has to be backfilled - each stale library still gets a libversion row every run, so the next run of a branch marks it. The reports that counted rows without asking for a phase now exclude the marker, and the two regression queries no longer report a model going Verify -> Removed as a regression. A library that fails to load has no models either, and marking every model of it removed on the strength of a failed download would drop it out of the reports for a day. Collect the libraries whose loadModel failed and refuse to run, so the reason is fixed rather than recorded. Assisted-by: Claude Opus 5
sjoelund
enabled auto-merge (squash)
August 25, 2026 04:26
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A library that still loads but has no model with an experiment annotation writes no rows into its branch table, so the newest date there stays at the last run that did have models and the reports go on listing them. Physiomodel lost its annotations in 2021 and master has reported its 12 models ever since; OpenHydraulics, IdealizedContact, Dynawo_1.6.1 and ModelicaTestOverdetermined_3.2.2 are in the same state, and Pharmacolibrary, ExtendedPetriNets, ExternalMemoryLib and Spot never had a model at all.
A run now writes a finalphase -1 row for every model the previous run of that library had and it no longer finds. The previous run is the newest one with rows for the library rather than the previous run of the branch, which makes it self-limiting: once written, the removals are themselves that library's newest rows, so a library that stays empty is marked once instead of at every run. Nothing has to be backfilled - each stale library still gets a libversion row every run, so the next run of a branch marks it.
The reports that counted rows without asking for a phase now exclude the marker, and the two regression queries no longer report a model going Verify -> Removed as a regression.
A library that fails to load has no models either, and marking every model of it removed on the strength of a failed download would drop it out of the reports for a day. Collect the libraries whose loadModel failed and refuse to run, so the reason is fixed rather than recorded.
Assisted-by: Claude Opus 5