Skip to content

Add a read memory barrier to the traversal of the buffer slot list #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 14 commits into from
Apr 13, 2020
Merged

Add a read memory barrier to the traversal of the buffer slot list #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
20d0cb2
Merge pull request #46 from xianyi/develop
martin-frbg Apr 13, 2020
d1d69e1
Add read barrier definition
martin-frbg Apr 13, 2020
8692456
Add read barrier definition
martin-frbg Apr 13, 2020
d237dc1
Add read barrier definition
martin-frbg Apr 13, 2020
25e879f
Add (empty) read barrier definition
martin-frbg Apr 13, 2020
ee6b3df
Add read barrier definition
martin-frbg Apr 13, 2020
99dde1d
Add read barrier definition
martin-frbg Apr 13, 2020
3d4db4d
Add read barrier definition
martin-frbg Apr 13, 2020
69b6e25
Add (empty) read barrier definition
martin-frbg Apr 13, 2020
db3226a
Add (empty) read barrier definition
martin-frbg Apr 13, 2020
a52bdd9
Add (empty) read barrier definition
martin-frbg Apr 13, 2020
f5efecb
Add (empty) read barrier definition
martin-frbg Apr 13, 2020
f41600e
Add a read barrier in the traversing of the buffer list
martin-frbg Apr 13, 2020
3eec7d3
ARMV7 does not support DMB ISHLD, use DMB ISH
martin-frbg Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common_alpha.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@

#define MB asm("mb")
#define WMB asm("wmb")
#define RMB asm("rmb")

static void __inline blas_lock(unsigned long *address){
#ifndef __DECC
Expand Down
2 changes: 2 additions & 0 deletions common_arm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#define MB
#define WMB
#define RMB

#else

#define MB __asm__ __volatile__ ("dmb ish" : : : "memory")
#define WMB __asm__ __volatile__ ("dmb ishst" : : : "memory")
#define RMB __asm__ __volatile__ ("dmb ish" : : : "memory")

#endif

Expand Down
2 changes: 1 addition & 1 deletion common_arm64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#define MB __asm__ __volatile__ ("dmb ish" : : : "memory")
#define WMB __asm__ __volatile__ ("dmb ishst" : : : "memory")

#define RMB __asm__ __volatile__ ("dmb ishld" : : : "memory")

#define INLINE inline

Expand Down
1 change: 1 addition & 0 deletions common_ia64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@

#define MB
#define WMB
#define RMB

#ifdef __ECC
#include <ia64intrin.h>
Expand Down
1 change: 1 addition & 0 deletions common_mips.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#define MB __sync_synchronize()
#define WMB __sync_synchronize()
#define RMB __sync_synchronize()

#define INLINE inline

Expand Down
1 change: 1 addition & 0 deletions common_mips64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#define MB __sync_synchronize()
#define WMB __sync_synchronize()
#define RMB __sync_synchronize()

#define INLINE inline

Expand Down
2 changes: 2 additions & 0 deletions common_power.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,11 @@
#if defined(POWER8) || defined(POWER9)
#define MB __asm__ __volatile__ ("eieio":::"memory")
#define WMB __asm__ __volatile__ ("eieio":::"memory")
#define RMB __asm__ __volatile__ ("eieio":::"memory")
#else
#define MB __asm__ __volatile__ ("sync")
#define WMB __asm__ __volatile__ ("sync")
#define RMB __asm__ __volatile__ ("sync")
#endif

#define INLINE inline
Expand Down
1 change: 1 addition & 0 deletions common_sparc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

#define MB __asm__ __volatile__ ("nop")
#define WMB __asm__ __volatile__ ("nop")
#define RMB __asm__ __volatile__ ("nop")

#ifndef ASSEMBLER

Expand Down
1 change: 1 addition & 0 deletions common_x86.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@

#define MB
#define WMB
#define RMB

#ifdef C_SUN
#define __asm__ __asm
Expand Down
3 changes: 3 additions & 0 deletions common_x86_64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,16 @@
#ifdef __GNUC__
#define MB do { __asm__ __volatile__("": : :"memory"); } while (0)
#define WMB do { __asm__ __volatile__("": : :"memory"); } while (0)
#define RMB
#else
#define MB do {} while (0)
#define WMB do {} while (0)
#define RMB
#endif

static void __inline blas_lock(volatile BLASULONG *address){


#ifndef C_MSVC
int ret;
#else
Expand Down
3 changes: 1 addition & 2 deletions common_zarch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define COMMON_ZARCH

#define MB
//__asm__ __volatile__ ("dmb ish" : : : "memory")
#define WMB
//__asm__ __volatile__ ("dmb ishst" : : : "memory")
#define RMB


#define INLINE inline
Expand Down
1 change: 1 addition & 0 deletions driver/others/memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2741,6 +2741,7 @@ void *blas_memory_alloc(int procpos){
LOCK_COMMAND(&alloc_lock);
#endif
do {
RMB;
#if defined(USE_OPENMP)
if (!memory[position].used) {
blas_lock(&memory[position].lock);
Expand Down