Repository navigation
fix(python): bump pyo3 to 0.29 for security advisories - #76
Merged
Merged
Conversation
pyo3 0.28.2 is compiled into the published wheels and is affected by two advisories fixed in 0.29.0: an out-of-bounds read in PyList/PyTuple iterator nth/nth_back (high), and a missing Sync bound on PyCFunction::new_closure (medium). No source changes were needed. Also refreshes the stale epaper-dithering-core entry in Cargo.lock (4.0.1 -> 6.0.0, a path dependency).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot flags
pyo3 0.28.2inpackages/python/Cargo.lock. Unlike dev-only dependencies, pyo3 is compiled into every published wheel. Both advisories are fixed in 0.29.0:nth/nth_backforPyList/PyTupleiterators.Syncbound onPyCFunction::new_closureclosures.Our binding most likely doesn't exercise either path (no closures; arguments are extracted, not iterated with
nth), but the fix is cheap and the dependency ships to users.What
pyo3 = "0.29"(resolves to 0.29.3). No source changes needed;cargo checkis clean.Cargo.lockdiff is only the five pyo3 crates plus the staleepaper-dithering-coreentry (4.0.1 → 6.0.0, a path dependency).Verification
maturin develop --releasebuilds and loads.As a
fix(python):commit, release-please will cut 6.1.1 so the patched wheels get published.