Repository navigation
chore: credit OpenDithering and include its MIT notice - #74
Merged
Merged
Conversation
dbs.rs is ported from OpenDithering's src/dithering/dbs.ts (MIT, Copyright (c) 2026 Guy Sie). MIT requires the copyright and permission notice in copies or substantial portions, so include it in full at the top of dbs.rs and in a new THIRD_PARTY_NOTICES.md that records the source file and commit.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #71 and #73. These two commits were pushed to the
docs/dbs-examplesbranch after #73 had already been merged, so they never reachedmain.dbs.rsis ported from OpenDithering'ssrc/dithering/dbs.ts(MIT, © 2026 Guy Sie). MIT requires the copyright and permission notice in copies or substantial portions. The full notice is now at the top ofdbs.rs(a plain comment, so it stays out of the rustdoc), and a newTHIRD_PARTY_NOTICES.mdrecords the source file and commit (2f579b9).Follow-up, not in this PR: the PyPI wheels and the npm package ship only compiled code, so they don't yet include the notice file. The crate and the sdist do include it, since they contain
dbs.rs.