Repository navigation
Add 5.1 surround sound - #341
Open
frankyfife wants to merge 1 commit into
Open
frankyfife wants to merge 1 commit into
frankyfife wants to merge 1 commit into
Conversation
The mixer outputs stereo or 5.1 (audio.channels: "auto", "stereo" or "5.1"; HALO_AUDIO_CHANNELS; Linux and Windows). On 5.1 the speaker config reports AC-3, as an Xbox set to Dolby Digital, so the game sends its 2D voices to the center and back mix bins itself; the speaker mix bins 0-5 are SDL's 5.1 channel order. 3D voices pan with equal power between adjacent speakers at the ITU-R BS.775 angles, spread out when close or above, at the stereo pan's power; stereo voices positioned in the world pan their middle the same way and keep their width on the front pair. The voices' resampling, low passes and reverb send are the stereo mix's; the reverb plays from the front and back pairs, the voice chat from the front pair, and the limiter takes all six channels. Stereo output mixes as before. Android and the web stay stereo. "auto" is the Xbox's own behaviour: the game asked the console's speaker setting and mixed for 5.1 when Dolby Digital was on. Checked on Windows with a 6-channel device: "sound: 5.1 surround" is logged and the device opens; with "stereo", and with no 6-channel device, the output is the stereo mix as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frankyfife
force-pushed
the
audio-aniso
branch
from
October 14, 2026 19:17
0bc2373 to
a85f6fd
Compare
frankyfife
changed the title
Author
|
I've taken anisotropic filtering out of this pull request in favour of #343, which does it better: it leaves the render targets alone (I hadn't checked the water's ripple map), applies a change without a restart, has a menu row, and doesn't default to a 16x departure from the Xbox's look. Thanks @startupfoundry for the comparison. This pull request is now only 5.1 surround sound, rebased on the current |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.1 surround sound for the desktop builds. (This pull request first also forced anisotropic filtering; that part is gone, see below.)
Change:
audio.channels(HALO_AUDIO_CHANNELS;"auto","stereo"or"5.1"; Linux and Windows).Default:
"auto"is 5.1 only when the sound device has six or more channels. That is the Xbox's own behaviour rather than a departure from it: the game asked the console's speaker setting and mixed for 5.1 when Dolby Digital was on. Happy to make it"stereo"if the project prefers.Test: Windows, release build on
main8102e71: with a 6-channel devicesound: 5.1 surroundis logged and the device opens; with"stereo", and with no 6-channel device, the output is the stereo mix. Not built for Android or the web here (they keep the stereo path, which is unchanged).🤖 Generated with Claude Code