Skip to content

fix(settings): 移除失效的 Windows 键盘列表开关 - #1385

Open
HKLHaoBin wants to merge 1 commit into
Open-Less:betafrom
HKLHaoBin:fix/issue-1376-remove-keyboard-toggle
Open

HKLHaoBin wants to merge 1 commit into
Open-Less:betafrom
HKLHaoBin:fix/issue-1376-remove-keyboard-toggle

Conversation

@HKLHaoBin

@HKLHaoBin HKLHaoBin commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

摘要

Fixes #1376.

删除 Windows 设置中已失效的「在键盘列表中显示 OpenLess」开关及误导文案,使界面与当前 speech TIP 架构保持一致。

历史关联:#1015 曾将该开关扩展到剪贴板粘贴模式;架构背景:#1143 将 Windows text service 改为 speech TIP,明确不再进入键盘列表。本 PR 不恢复旧 keyboard TIP 或输入法切换行为。

修复 / 新增 / 改进

  • 删除录音与输入设置中的失效开关、专用事件处理及显示判定。
  • 清理全部八种界面语言中相关的标签、恢复显示承诺和专用错误文案。
  • 保留插入方式保存、换行设置以及共享设置 provider 的错误反馈;不再把插入方式保存失败误报为键盘列表更新失败。
  • 增加跨平台源码契约回归,检查旧控件/文案消失,同时保护旧字段兼容与 speech profile 始终启用;保留有效的插入方式/换行选项测试。

兼容

  • 不包含:TSF DLL 注册类别、服务启停、输入法激活/恢复或文字插入行为的改动。
  • 保留 windowsShowOpenlessInKeyboardList 的序列化字段、默认值及云同步格式,兼容既有配置。
  • 无依赖和构建流程变更。所有测试和产物构建均在 GitHub Actions 执行,没有本地测试、依赖安装或产品构建。

测试计划

提交:1c25f5ccad32e494499d0e7abbd02b04b85dcfd4。

  • 独立 review-diff-bugs 审查返回 no bug found;提交前核对全部候选文件哈希一致。
  • fork CI 中 Windows 前端/契约与后端、Chromium + WebKit UI、Android、Harmony、Linux 测试及 deb/rpm 构建通过。
  • fork CI 整体通过:原 SHA 两次运行均因 macOS ARM 托管 runner 容量不足而取消对应任务;此项未通过,不以其他平台结果替代。
  • 桌面构建:Windows x64、macOS ARM64、macOS x64 全部通过,对应主产物已核对 SHA、非空且未过期。
  • Android 构建:arm64-v8a、armeabi-v7a、x86、x86_64 全部通过,四个 release APK artifact 已核对 SHA、非空且未过期。
  • 本 PR 上游 CI 尚未全部通过:首轮三个 macOS ARM 任务因 GitHub hosted runner 容量不足在执行前取消(零执行步骤);其他适用任务通过。完整日志及平台错误注解已保存。按用户决定,保留代码和工作流不变,等待 ARM runner 资源恢复;不能用 fork 构建或取消任务替代通过。
  • PR iOS test 任务通过(共享 Core、Swift 契约及接口资源等)。
  • PR iOS device-build 未通过:GitHub hosted runner 未分配,任务在执行前取消,零执行步骤;无构建错误日志,已有平台错误注解及其他任务完整日志归档。
  • Windows 实机安装后的 UI 验收(未声称已执行)。

Actions 证据:

分支构建仅上传 Actions artifacts,未发布 tag 或 Release。

Remove the inert visibility control and misleading messages in all eight locales. Preserve legacy preference compatibility and the always-enabled speech TIP. Add a removal regression contract. Refs Open-Less#1376.
@HKLHaoBin HKLHaoBin added bug Something isn't working needs-review Needs review platform:windows Windows-specific area:ui UI area area:ime IME area area:i18n i18n area labels Nov 4, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-04T15:07:28.729377Z
We couldn’t complete this review. Comment @codex review to try again.
1c25f5c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n i18n area area:ime IME area area:ui UI area bug Something isn't working needs-review Needs review platform:windows Windows-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[area] 在键盘列表中打开后,键盘列表中仍然不显示openless

1 participant